31

Say I have a class "ClassA", which has a dependency on a class "ClassB" (injected into the constructor of ClassA). I want to mock ClassB so that I can test ClassA in isolation. Both classes are internal.

Correct me if I'm wrong but it looks like Moq can only mock a class if it is public, it has a public parameterless constructor, and the methods to be mocked are public virtual. I don't really want to make these classes publicly visible. Am I missing something with Moq, or is it just not suitable for what I want to do?

I guess I could create an interface (say "IClassB") that ClassB implements, inject that into ClassA, and mock the interface instead. ClassB can still be internal (although I realise the interface methods would have to be public). While this would work, I feel uneasy about creating lots of interfaces, whose only purpose is to support unit test mocking. Thoughts?

BenKoshy
  • 33,477
  • 14
  • 111
  • 80
Andrew Stephens
  • 9,413
  • 6
  • 76
  • 152

2 Answers2

73

You could make internals visible to Moq by adding InternalsVisibleToAttribute in your project's assembly.cs, like this:

[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]

Why "DynamicProxyGenAssembly2" and not "Moq"? It's the name of dynamic assembly created to contain dynamically generated proxy types (all of this is handled by yet another library, Castle's DynamicProxy) which is used by Moq. So you expose types to dynamic proxy assembly, not to Moq itself.

But, what's the point of mocking class if there's no overridable member? You won't mock anything and all calls will use actual implementation. Your second solution,

I guess I could create an interface (say "IClassB") that ClassB implements, inject that into ClassA, and mock the interface instead.

is what I would normally do. Its purpose is much more than "to support unit test mocking" - it helps you build losely coupled components, which is always something worth aiming for.

Chris Marisic
  • 32,487
  • 24
  • 164
  • 258
k.m
  • 30,794
  • 10
  • 62
  • 86
  • Useful to know, thanks. However I've now decided to keep the classes public (at least those being tested). I think I was getting hung up on trying to make everything internal, but it's only a desktop app so it isn't as crucial as it would be in (say) an assembly/API that was being given to customers. – Andrew Stephens Jul 10 '13 at 15:20
  • Very helpful post, i was very confused by InternalsVisibleTo("IntegrationTests") wasn't working. Then it made sense that it's not my assembly accessing it but Castle's dynamically created assembly. – Chris Marisic Apr 13 '16 at 19:00
2

Also, you can add this into .csporj file.

<ItemGroup>
  <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
  <_Parameter1>DynamicProxyGenAssembly2</_Parameter1>
  </AssemblyAttribute>
</ItemGroup>
Support Ukraine
  • 978
  • 6
  • 20