20

I want to use auto-layout for UITableViewCells. These table cells have a dynamic height (depending on text length).

I'm using [UIView -systemLayoutSizeFittingSize:] to calculate the appropriate cell height (to return in [UITableView -heightForRowAtIndexPath:]) but I keep getting the following results:

  • If I pass UILayoutFittingCompressedSize, I get back a CGSize of (0,0).

  • If I pass UILayoutFittingExpandedSize, my app crashes with this error:

    *** Assertion failure in -[NSISLinearExpression incrementConstant:], /SourceCache/Foundation_Sim/Foundation-1043.1/Layout.subproj/IncrementalSimplex/NSISLinearExpression.m:620

(My guess is that this means some number is infinite.)

My implementation is simple. I calculate the height for each object, and then cache it:

MessageCell *cell = // allocate a new cell...

//  set up the cell (assign text, images, etc)

CGSize size = [cell systemLayoutSizeFittingSize:UILayoutFittingCompressedSize];

self.cellHeight = size.height;  // size always equals (0, 0)

I hypothesize that this is a problem with the constraints I set, but:

  • If I manually set cellHeight to a large value, the cells all look fine except the height is wrong.
  • Interface Builder gives me no warnings about ambiguous restraints
  • [cell hasAmbiguousLayout] returns NO.
  • My cell has, among other things, an image set at 48x48, so a size of (0, 0) shouldn't satisfy all the constraints.

Any ideas?

Community
  • 1
  • 1
Aaron Brager
  • 65,323
  • 19
  • 161
  • 287

2 Answers2

38

This is what works for me (note 'contentView')

CGSize size = [cell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize];

EDIT: I answered a similar question and provided a complete example, here:

How to resize superview to fit all subviews with autolayout?

Community
  • 1
  • 1
TomSwift
  • 39,369
  • 12
  • 121
  • 149
  • This was the key for me. If I have my auto layout constraints just right, then all I need to do in [UITableView -heightForRowAtIndexPath:] is return [cell.contentView systemLayoutSizeFittingSize:UILayoutFittingCompressedSize].height; and rows resize to their new layout. Simple. – Chuck Krutsinger Aug 01 '14 at 15:42
2

It is hard to say something concrete basing on your post because you didn't post constraints that you use. Apple Documentation:

systemLayoutSizeFittingSize:

Returns the size of the view that satisfies the constraints it holds.

Maybe you created constraints that can be interpreted in the way the size of the cell is equal to (0,0).

There is another way you can check the height of the cell with the text. You can put your text in the UITextView and then:

UITextView textView; 
textView.text = @"l";
textView.font = [UIFont fontWithName:FONT_NAME size:FONT_SIZE];
//some code here
//
CGFloat cellHeight = textView.contentSize.height;

It is important to set the text and font (and every other property that can cause the change of the height of the UITextView) of the UITextView before using contentSize property. Also you must first add UITextView to the view.

////// EDIT

The problem with your approach with using constraints can be that you want to measure the cell which ISN'T added to the view so the system don't have all the informations it needs. It doesn't know how much space that will be for the space etc because it doesn't know the surrounding area of the cell

Rafał Augustyniak
  • 2,011
  • 19
  • 14
  • The latter approach is what I'm doing now, and what I want to stop doing. (Well, I'm using `[NSString -sizeWithFont: constrainedToSize:]`, but the same basic idea). My UITableViewCell contains a subview, a UIImageView, with four constraints (height = 48, width = 48, leading space to container = 10, top space to container = 10). Shouldn't that alone make `systemLayoutSizeFittingSize:` return, at minimum, (58, 58)? – Aaron Brager Jul 10 '13 at 16:52
  • It sounds like it should work. You hold your image in UIImageView and it is added to the cell view? Also, I think that this idea with using UITextView is probably better than using NSString methods because i had some problems with NSString when working with multiline strings. – Rafał Augustyniak Jul 10 '13 at 17:25