move_uploaded_file not moving

Question

I'm working on a backoffice to uploaded images so you can change the images in the front. Problem is my upload script isn't returning me any errors to work with, but it's also not moving the file. I want my script to upload the new file to that location and replace any file with the same name regardless, but I'd have to get the moving working first.

Where am I going wrong?

================================================================================== EDIT: I've added the slash to the path. It still won't upload my image though. Code is as follows:

$target_path = "../../site/images/user_images/";
$image_name = $_POST['filename'].".".pathinfo($_FILES['file']['name'],PATHINFO_EXTENSION);

if(move_uploaded_file($_FILES['file']['tmp_name'], $target_path.$image_name)) {
    echo "<meta http-equiv='refresh' content='0;URL=images.php?saved=true' />";
} else {
    echo "Error";
}

Now it jumps into the else {}, but echo $_FILES['file']['error']; returns me a 0. — Parrotmaster, Jul 15 '13 at 11:35
Turn on some error reporting http://stackoverflow.com/questions/6575482/how-do-i-enable-error-reporting-in-php — soulseekah, Mar 15 '14 at 05:38

score 3 · Answer 1 · answered Jul 15 '13 at 10:27

$target_path = "../../site/images/user_images/";
                                             ^

Here you are forgetting / which tells that it is directory where you have to upload the file.

So $target_path.$image_name will become like this

../../site/images/user_images/newfile.png

Else your code produce this output

../../site/images/user_imagesnewfile.png

score 1 · Accepted Answer · answered Jul 15 '13 at 10:29

1

You're missing the trailing slash. You need:

$target_path = "../../site/images/user_images/";

answered Jul 15 '13 at 10:29

Thanks, that fixed the issue of not uploading. Except now it uploads the file with the wrong name (due to $target_path.$image_name in my code i presume). Would you know how to upload it with the proper name to the location? When I try ($target_path, $image_name) instead it returns "Error". Also it uploaded it to the folder above user_images, so it ended up in images/ instead – Parrotmaster Jul 15 '13 at 10:50
@Parrotmaster: It should work. Analyze the [`error codes`](http://www.php.net/manual/en/features.file-upload.errors.php) and find out what's wrong. – Jul 15 '13 at 11:02
@Parrotmaster: yes, that's the default behaviour. You'll have to request it explicity. `echo $_FILES['file']['error'];` – Jul 15 '13 at 11:08
Yes I know, it's returning 0. – Parrotmaster Jul 15 '13 at 11:09
Apparently it is working. My FTP client didn't how the images even after a few reloads. – Parrotmaster Jul 15 '13 at 12:01

score 0 · Answer 3 · answered Jul 15 '13 at 10:27

0

add slashe to end of the path variable, and try again.

$target_path = "../../site/images/user_images/";

answered Jul 15 '13 at 10:27

jaydeep namera

1,024
7
15

score 0 · Answer 4 · answered Jul 15 '13 at 10:28

0

have you added enctype in your form?

<form name="form1" id="form1" method="post" action="" enctype="multipart/form-data">
</form>

answered Jul 15 '13 at 10:28

chirag ode

950
7
15

score 0 · Answer 5 · answered Jul 15 '13 at 10:29

0

$target_path = $_SERVER['DOCUMENt_ROOT']."your/folder/relat";

the path should be complete path and after that assign proper permissions to the folder

answered Jul 15 '13 at 10:29

DynamicDeveloper

33
8

move_uploaded_file not moving

5 Answers5