codeigniter pagination pulling item more then once

Question

This is a very irritating issue. I have my codeigniter pagination set up and so I thought working, but looking at it closer it seems that on the last page it's pulling in previous results to fill the page in.

So say I want ten per page and have fourteen results. The first page has ten results, and so does the second. When it should be the first has ten and the second has four. It would be fine if it was just repeating one result, but it's irritating to have to scroll through six previous results. Any help would be much appreciated.

in my controller I have the pagination code

$config = array();
$config["base_url"] = base_url()."myStories/".$id;
$config["total_rows"] = $this->data_model->my_count();
$config["per_page"] = 10;
$config["uri_segment"] = 3;
$config['num_links'] = 2;
$choice = $config["total_rows"] / $config["per_page"];
//$config["num_links"] = round($choice);

$this->pagination->initialize($config);
$page = ($this->uri->segment(3)) ? $this->uri->segment(3) : 0;

$this->load->view('userStory_view', array(
    'query' => $this->data_model->pullMyStories($config['per_page'], $page),
    'links' => $this->pagination->create_links(),
    'user' => $this->users_model->getUser($this->user->user_id),
)); 

and then in my model I have the count and then the actual results coming back

public function my_count() {
        //This counts all the stories that belong to that author
        $author = $this->uri->segment(2);
        $this->db->where('author', $author);
        $this->db->where(array('approved !=' => 'd'));
        $query = $this->db->get('story_tbl');
        return $query->num_rows();
       }

    public function pullMyStories($limit, $start){
        //This pulls back all the stories that belong to that author
        $this->db->limit($limit, $start);
        $this->db->order_by("date", "desc");
        $author = $this->uri->segment(2);
        $this->db->where(array('approved !=' => 'd'));
        $this->db->where('author', $author);
        $story = $this->db->get('story_tbl');
        return $story->result();    
    }

the route I have set up that does work

$route['myStories/(:any)'] = "story/viewStories/$1";

I thought initially that my count was count was wrong, but even with a count of 14, 20 results come back.

For further information I am more than positive that my baseUrl is correct. I have modified my .htaccess to get rid of the index.php and have edited my route file to make the controller disappear from the url. To try and make it easy to remember for the user.

I am also very sure that the uri segments are correct. If they were not correct then my page would not be coming up at all.

I have tried all the normal solutions and nothing has worked. That is why I am asking here and why I have placed a bounty on this question.

Answer 1

var $base_url           = ''; // The page we are linking to
var $prefix             = ''; // A custom prefix added to the path.
var $suffix             = ''; // A custom suffix added to the path.

var $total_rows         =  0; // Total number of items (database results)
var $per_page           = 10; // Max number of items you want shown per page
var $num_links          =  2; // Number of "digit" links to show before/after the currently viewed page
var $cur_page           =  0; // The current page being viewed
var $use_page_numbers   = FALSE; // Use page number for segment instead of offset
var $first_link         = 'First';
var $next_link          = '->';
var $prev_link          = '<-';
var $last_link          = 'Last';
var $uri_segment        = 2;
var $full_tag_open      = '';
var $full_tag_close     = '';
var $first_tag_open     = '';
var $first_tag_close    = ' ';
var $last_tag_open      = ' ';
var $last_tag_close     = '';
var $first_url          = ''; // Alternative URL for the First Page.
var $cur_tag_open       = '&nbsp;<strong>';
var $cur_tag_close      = '</strong>';
var $next_tag_open      = '&nbsp;';
var $next_tag_close     = '&nbsp;';
var $prev_tag_open      = '&nbsp;';
var $prev_tag_close     = '';
var $num_tag_open       = '&nbsp;';
var $num_tag_close      = '';
var $page_query_string  = FALSE;
var $query_string_segment = 'per_page';
var $display_pages      = TRUE;
var $anchor_class       = '';

Answer 2

Your problem is that you are passing the wrong parameters to your pullMyStories method. On the first page you will be apply the following limit to your query

LIMIT 0,10

Then on the second page

LIMIT 1,10

Then on the third

LIMIT 2,10

So you pagination is only moving forward one item at a time instead of ten. So you need to change this

'query' => $this->data_model->pullMyStories($config['per_page'], $page),

To this

'query' => $this->data_model->pullMyStories($config['per_page'], ($page * $config['per_page'])),

Answer 3

Try if it works for you:

$config = array();
$config["base_url"]     = base_url()."myStories/";         #change in base url
$config["total_rows"]   = $this->data_model->my_count();
$config["per_page"]     = 10;
$config["uri_segment"]  = 3;
$config['num_links']    = 2;
#$choice = $config["total_rows"] / $config["per_page"];
//$config["num_links"] = round($choice);

$this->pagination->initialize($config);
#$page = ($this->uri->segment(3)) ? $this->uri->segment(3) : 0;  #no need of calculation here

$this->load->view('userStory_view', array(
    'query' => $this->data_model->pullMyStories($this->uri->segment(3)),   #change here send the offset directly
    'links' => $this->pagination->create_links(),
    'user' => $this->users_model->getUser($this->user->user_id),
)); 

function pullMyStories($offset = 0){
    $story = $this->db->where('author', $this->uri->segment(2))->where('approved != d')->order_by("date", "desc")->get('story_tbl', 10, $offset);
    return $story->result();
}

Answer 4

I recently tried so hard to about ci pagination.

I think, your codes right.

What exactly uri string on second page?.. And this listing function is index() ?

Answer 5

Try this. You just need to change the base_url in the correct way. Also be careful and check if you are getting a right number for uri_segment. If not, you can change the number, and get the correct.

    // $config = array();
    // MUST CHNGE IT I just tell the with simple example. If you have index.php, c name and method name.
    $config["base_url"] = base_url()."index.php/controller_name/function_name/"; 
    $config["total_rows"] = $this->data_model->my_count();
    $config["per_page"] = 10;
    $config["uri_segment"] = 3; // BE CARFULL with uri_segment. You need to print it, and be shre that you are getting the right number
    $config['num_links'] = 2;


    $this->pagination->initialize($config);
    $page = ($this->uri->segment(3)) ? $this->uri->segment(3) : 0;

    $this->load->view('userStory_view', array(
        'query' => $this->data_model->pullMyStories($config['per_page'], $page),
        'links' => $this->pagination->create_links(),
        'user' => $this->users_model->getUser($this->user->user_id),
    ));

I update my code, I comment and $config = array(); I did it today in my computer this, and it works. I know that you maybe checked it hundred times, but Check in details it again.

UPDATE with my example:

function index() {

        $data['page_title'] = "Items";

        $config['base_url']         = base_url() .'index.php/items/index/';
        $config['total_rows']       = $this->items_model->count_items(); // Count items from DB
        $config['per_page']         = 10; 
        $config['uri_segment']      = 3;
        // Customize 
        $config['next_link']        = FALSE;
        $config['prev_link']        = FALSE;
        $config['first_link']       = 'first';
        $config['last_link']        = 'last';
        $config['cur_tag_open']     = '<a class="current">';
        $config['cur_tag_close']    = '</a>';

        $this->pagination->initialize($config); 

        $page                       = ($this->uri->segment(3)) ? $this->uri->segment(3) : 0;
        $data['items']              = $this->items_model->get_items($config["per_page"], $page);


        $this->load->view('invoice-items', $data);

    }

Answer 6

In your controller:

$page = $this->uri->segment(3,0);

Then:

public function pullMyStories($limit, $start){

$author = $this->uri->segment(2);

$this->db
  ->select('*')
  ->where('approved !=', 'd')
  ->where('author', $author)
  ->order_by('date', 'DESC')
  ->limit($limit, $start);

$story = $this->db->get('story_tbl');

return $story->result(); 

Also where do you load the library using the line below?

$this->load->library('pagination');   

Answer 7

I'm just gonna throw this in and hope it helps in some way, because I've tested and it works for me. I've made the following assumptions for testing:

• id (as in "myStories/".$id in the controller) is taken from $this->uri->segment(2)
• story_tbl fields I created were id, author, date

My test files were as follows:

Controller MyStories.php:

    public function index()
    {
            //loading library, model, and assumptions
        $this->load->library('pagination');
        $this->load->model('m_page', 'data_model');
        $id = $this->uri->segment(2);
        //
        //
        //Your code from here...
        //
        //
        $config = array();
        $config["base_url"] = $this->config->site_url("myStories/".$id);
        $config["total_rows"] = $this->data_model->my_count();
        $config["per_page"] = 3;
        $config["uri_segment"] = 3;
        $config["num_links"] = round($config["total_rows"] / $config["per_page"]);

        $this->pagination->initialize($config);
        $page = ($this->uri->segment(3)) ? $this->uri->segment(3) : 0;

        $data = array();
        $data['query'] = $this->data_model->pullMyStories($config['per_page'], $page);
        $data['links'] = $this->pagination->create_links();
        $data['config'] = $config;
        //$data['user'] = $this->users_model->getUser($this->user->user_id);
        $this->load->view('userStory_view', $data);     
    }

BTW, you really want to be using the site_url and not base_url when defining the pagination base_url.

I also commented out the 'user' data in the controller simply because you never gave any info on that.

My test view, userStory_view.php:

<?php echo $links;?>
<!-- -->
<hr>
total rows: <?php echo $config['total_rows'];?>
<hr>
<?php echo $this->db->last_query();?>
<hr>
<!-- -->
<?php foreach ($query as $row):?>
<?php echo $row->author.'<hr>';?>
<?php endforeach;?>

I made no changes to your Model, so no need to show that here.

I added the following line to routes.php:

$route['myStories/(:any)'] = "myStories";

As I said, everything worked for me. Besides my formatting, the only changes I really made were the use of site_url() instead of base_url(), and the commenting of the user data. So pretty stuck as to why you're having issues I'm afraid.

Answer 8

As far as it seems your overall pagination functionality seems to correct. what i want check would the sql query returned in each function and parameters passed to those function coz $author variable has to global and try

$this->db->last_query();

on your both functions my_count() and pullMyStories($limit, $start) and check those function returning right results.

U might also can try writing direct sql query with changing parameters like.

$sql = "SELECT * FROM some_table WHERE author = ? LIMIT ?, ?";

$this->db->query($sql, array($author, $start, $limit)); 

As i am seeing this would be mostly of query might have been wrong . Hope this helps.