Android - Unable to destroy activity after finish, caused by IllegalStateException: Can not perform this action after onSaveInstanceState

Question

I have an activity in my app with 3 fragments. When a button is pushed on the first one, a method is called in the Activity that does some irrelevant stuff and then calls finish().

This triggers onPause() on the fragment, which does more irrelevant stuff and then calls super.onPause().

The app then loads the old Activity it came on (logically following the view stack), and suddenly crashes with the following exception when onDestroyView() is called on the Fragment:

FATAL EXCEPTION: main
java.lang.RuntimeException: Unable to destroy activity {be.niteowl.niteowl.debug/be.niteowl.niteowl.views.activities.VenueActivity}: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:2793)
at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:2811)
at android.app.ActivityThread.access$2100(ActivityThread.java:123)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:972)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:130)
at android.app.ActivityThread.main(ActivityThread.java:3835)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:507)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at android.support.v4.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1327)
at android.support.v4.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1338)
at android.support.v4.app.BackStackRecord.commitInternal(BackStackRecord.java:595)
at android.support.v4.app.BackStackRecord.commit(BackStackRecord.java:574)
at be.niteowl.niteowl.views.activities.TrackFragment.onDestroyView(TrackFragment.java:161)
at android.support.v4.app.Fragment.performDestroyView(Fragment.java:1665)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:980)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1088)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1070)
at android.support.v4.app.FragmentManagerImpl.dispatchDestroy(FragmentManager.java:1898)
at android.support.v4.app.FragmentActivity.onDestroy(FragmentActivity.java:324)
at com.actionbarsherlock.app.SherlockFragmentActivity.onDestroy(SherlockFragmentActivity.java:88)
at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:2780)
... 11 more

The error appears to happen when trying to remove a MapFragment from the main Fragment. I know that you're not supposed to have fragments within fragments, but the code worked in the past and there's no way around it anyway.

@Override
public void onDestroyView() {
    SupportMapFragment f = (SupportMapFragment) activity.getSupportFragmentManager().findFragmentById(R.id.fragment_map);
    if (f != null) {
        activity.getSupportFragmentManager().beginTransaction().remove(f).commit();
    }
    super.onDestroyView();
}

I looked around for a fix here on SO already (most notably getting exception "IllegalStateException: Can not perform this action after onSaveInstanceState"), but none of them were applicable to my current problem.

have you actually made sure its running before the savedinstancestate? — Broak, Jul 17 '13 at 13:30

score 20 · Answer 1 · answered Apr 12 '14 at 18:17

20

The following code worked for me. It is placed in the fragment that calls the map fragment

@Override
public void onDestroy() {

    SupportMapFragment f = (SupportMapFragment) getActivity().getSupportFragmentManager().findFragmentById(R.id.mapView);
    if (f.isResumed()){ 
        getFragmentManager().beginTransaction().remove(f).commit();
    }

    super.onDestroy();
}

answered Apr 12 '14 at 18:17

lytridic

325
4
8

thanks man, the crash was when I was trying to close the app and your code fix it – NDM Apr 23 '14 at 12:53
2

f.isResumed() worked for me too, i was just using f != null (which I think shoud be in your code as well), thanks a lot! – Analizer Jul 06 '14 at 16:43
finally! did it for me too! – lisa Aug 12 '14 at 11:14

score 8 · Accepted Answer · answered Jul 17 '13 at 13:40

8

Since your activity is being destroyed, your fragments will automatically be destroyed. Hence, there is no need for you to remove them. Simply delete your onDestroyView() method.

I know that you're not supposed to have fragments within fragments, but the code worked in the past and there's no way around it anyway.

First, fragments within fragments are supported via the Android Support package's backport of fragments and the native Android 4.2+ implementation of fragments.

Second, you are not doing fragments within fragments, at least not based on the code shown here. For some reason, your TrackFragment is managing another top-level fragment (your SupportMapFragment), rather than delegating that work to the activity.

answered Jul 17 '13 at 13:40

CommonsWare

986,068
189
2,389
2,491

Thanks, that was indeed somewhat of a fix. However, now I have issues when going away to a 3rd tab and then going back: FATAL EXCEPTION: main android.view.InflateException: Binary XML file line #96: Error inflating class fragment at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:587) ... (too long for this comment) – Vindicator Jul 17 '13 at 14:09
@Vindicator: Perhaps open a new StackOverflow question, where you can show the entire stack trace and the relevant XML and Java code. – CommonsWare Jul 17 '13 at 14:11
@Vindicator this seems to fix the issue: http://stackoverflow.com/a/17422251/732489 – Quentin Jul 17 '13 at 14:20

score 0 · Answer 3 · answered Aug 20 '14 at 14:09

Committing transactions in OnPostResume() callback fixed the issue for me. Thanks to following blogpost http://www.androiddesignpatterns.com/2013/08/fragment-transaction-commit-state-loss.html

@Override
protected void onPostResume() {
    super.onPostResume();
    // Commit your transactions here.
}

score 0 · Answer 4 · answered Jul 28 '16 at 22:06

0

As your activity is destroyed which causes the fragments to be destroyed, .commit() cannot be handled.

Remove getSupportFragmentManager().beginTransaction().remove().commit().

Try handling in onBackPressed(), which I did for my application

answered Jul 28 '16 at 22:06

ranjith Gampa

105
2
12

score 0 · Answer 5 · answered Jan 07 '22 at 09:27

0

I fixed it using below code in the activity:

 @Override
    public void onDestroy() {
        try{
            super.onDestroy();
        }catch (NullPointerException e){

        }
    }

answered Jan 07 '22 at 09:27

Narender Bhadrecha

87
2
9

Android - Unable to destroy activity after finish, caused by IllegalStateException: Can not perform this action after onSaveInstanceState

5 Answers5