Can anyone give me an alternative solution to this code?

Question

I am new in php and want to explore how the same thing can be achieved in different ways. I have the following working code and would like to see better ways of coding. Any suggestion is appreciated.

<?php
$districts = "Aizawl";

$fc = "First City";
$sc = "Second City";
$tc = "Third City";

if ($districts == "Aizawl") {
    $city = $fc;
} elseif ($districts == "Lunglei") {
    $city = $sc;
} elseif ($districts == "Saiha") {
    $city = $tc;
}
?>
<?php
echo $city;
?>

Use a switch statement - http://php.net/manual/en/control-structures.switch.php — Darren, Jul 24 '13 at 13:32
This question appears to be off-topic because it is about code review and would be better at http://codereview.stackexchange.com. — deceze, Jul 24 '13 at 13:34
And get an IDE, netbeans is a free alternative. It automagically indents code, making it prettier ^^ — JimL, Jul 24 '13 at 13:35
I don't think this fits better in code review. It is very similar to the question of [how to avoid the arrow head antipattern](http://stackoverflow.com/questions/17804005/how-to-prevent-the-arrowhead-anti-pattern) — Carlos Campderrós, Jul 24 '13 at 13:39

score 3 · Accepted Answer · answered Jul 24 '13 at 13:38

3

<?php
$districts = "Aizawl";

$districts_city = array(
    'Aizawl' => 'First City',
    'Lunglei' => 'Second City',
    'Saiha' => 'Third City',
);

$city = $districts_city[$districts];
echo $city;

answered Jul 24 '13 at 13:38

srain

8,944
6
30
42

Your code is the fastest. – The Reaper Jul 24 '13 at 13:57
@Carlos Campderrós I have been trying. my connnection is slow! – The Reaper Jul 24 '13 at 14:26

score 2 · Answer 2 · answered Jul 24 '13 at 13:38

2

$districts = 'Aizawl';

$map = array(
  'Aizawl' => 'First city',
  'Lunglei' => 'Second city',
  'Saiha' => 'Third city',
);

if (isset($map[$districts])) {
  $city = $map[$districts];
} else {
  // show error...
}

answered Jul 24 '13 at 13:38

Carlos Campderrós

22,354
11
51
57

Thank you for giving me your time. – The Reaper Jul 24 '13 at 14:01

score 2 · Answer 3 · answered Jul 24 '13 at 13:40

2

Use an associative list or a hash table.

$array = array(
    "Aizwal" => "First City",
    "foo" => "2nd",
    "bar" => "3rd",
);

$city=$array[$districts]

answered Jul 24 '13 at 13:40

rjv

6,058
5
27
49

score 0 · Answer 4 · answered Jul 24 '13 at 13:38

0

Bellow code ill be help ful

<?php
 $i=2;

 switch ($i) {
case 0:
    echo "i equals 0";
    break;
case 1:
    echo "i equals 1";
    break;
case 2:
    echo "i equals 2";
    break;
 }
 ?>

answered Jul 24 '13 at 13:38

backtrack

7,996
5
52
99

score -1 · Answer 5 · edited Jul 24 '13 at 13:42

-1

Use a switch statement

switch ($districts) {
case "Aizawl":
    $city=$fc;
    break;
case "Lunglei":
    $city=$sc;
    break;
case "Saiha":
    $city=$tc;
    break;
}

edited Jul 24 '13 at 13:42

answered Jul 24 '13 at 13:34

Nigel B

3,577
3
34
52

score -1 · Answer 6 · answered Jul 24 '13 at 13:35

Use a switch statement. Also if you aren't using the $fc, $sc, and $tc, variables elsewhere, I would just set the $city variable to the string contents inside the switch statement.

<?php

$districts="Aizawl";

$fc="First City";
$sc="Second City";
$tc="Third City";

switch($districts) {
    case "Aizawl":
        $city=$fc;
        break;
    case "Lunglei":
        $city=$sc;
        break;
    case "Saiha":
        $city=$tc;
        break;
}

echo $city;

Can anyone give me an alternative solution to this code?

6 Answers6