UIButton background image not changing

Question

I want to change button background image as per the web service response. if in response I get unread messages to true then image will different and if there is no unread messages image will be different. I am getting the response very well but not able to change my button's background image.

This is the snippet I am using

if(unread>0){
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];
}
else{
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] forState:UIControlStateNormal];
}

Have you tried debugging to see what value unread assumes? Maybe the problem is that it doesn't have the value that you expect. A bit more of context, showing more source code would help. — Ramy Al Zuhouri, Jul 26 '13 at 10:27
@RamyAlZuhouri I already debugged it and it is goes in right condition but cant change the image. dont know why — KDeogharkar, Jul 26 '13 at 10:28
Did you set image in xib? remove them or set only background image in xib and try again please if you did. — Yucel Bayram, Jul 26 '13 at 10:30
setting in code is the latest working option ,so setting in xib i dont think is a factor — Lithu T.V, Jul 26 '13 at 10:38
The UIControlState parameter is not a bitmask, you should call the method twice for UIControlStateNormal and UIControlStateSelected. — Ramy Al Zuhouri, Jul 26 '13 at 10:39
but @yucelbayram it doesnt make sense because if i remove the background from xib it will give me right image after that but when i click i again want to change but it is not changing. — KDeogharkar, Jul 26 '13 at 10:40
@BaZinga you need to reload the view for it or on button press you have to change the unread message value — 9to5ios, Jul 26 '13 at 10:43
@BaZinga mate paste your button image changer code in viewDidload and check if its working code please. — Yucel Bayram, Jul 26 '13 at 10:47
no in view did load its also not changing. please help me guyzzzz — KDeogharkar, Jul 26 '13 at 10:49
viewDidLoad load only once the view is load you need to call the view again i think — 9to5ios, Jul 26 '13 at 10:53
@iphonemaclover yes it load once , i just said it for check it out code working or not because if image going to change once than its easy to change it again with if and else statements in button actions or wherever you want, you know. — Yucel Bayram, Jul 26 '13 at 10:58
In .xib put read.png as background image to your button. Then add following to your code; if(unread>0){ [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal]; } — Engnyl, Jul 26 '13 at 11:10
you are right @yucelbayram thats why set background image method is there. — KDeogharkar, Jul 26 '13 at 11:19

score 7 · Accepted Answer · edited Dec 13 '17 at 11:03

7

The solution can be very simple, if you look at it. Keep a global UIButton and not a local one. This helps, as when the web request returns back a response, the button needs to be present in-scope and not get removed from the memory.

So use,

self.myButton = [UIButton buttonWithType:UIButtonTypeCustom];

[self.myButton setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];

OR

[self.myButton setImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];

And, if you checking on the click of a button, then follow the steps :

-(IBAction)checkForMsgCount: (id)sender
{
  UIButton *buttonObj = (UIButton*)sender;

[buttonObj setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];
}

This changes the background image, for the button that is responding to the function.

edited Dec 13 '17 at 11:03

KDeogharkar

10,939
7
51
95

answered Jul 26 '13 at 10:44

Hitesh

542
3
12

that doesnt make any sense and I debug for so many time if button is removed or not but it is there all the time. – KDeogharkar Jul 26 '13 at 10:46
the solution indicates clearly, that you need to be clear, as to WHAT button is responding to the method. This can be used by, type casting the sender object, to a UIButton, and then changing the image to it. TRY THIS and TELL IF IT DOES NOT WORK – Hitesh Jul 26 '13 at 11:39
I have myself used this. Telling you, it will work. Just try it ! – Hitesh Jul 26 '13 at 11:41

Yucel Bayram · Answer 2 · 2013-07-26T11:49:51.860

[YourBtn setImage:[UIImage imageNamed:@"your.png"] forState:UIControlStateNormal];

try it please.

Can you also try this for check it out if you really have this pictures in your bundle ?

        NSString *bundlePath = [[NSBundle mainBundle] bundlePath];
        NSString *imagePath = [[NSString alloc] initWithFormat:@"%s/yourButton.png", [bundlePath  UTF8String]];


if ([[NSFileManager defaultManager] fileExistsAtPath:imagePath]) {
    NSLog(@"image exists");
}
else{
    NSlog(@"image Does Not Exist");
      }

score 1 · Answer 3 · edited Jul 26 '13 at 11:03

1

please try code below

if(unread>0){
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState :UIControlStateSelected];
}
else{
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] forState:UIControlStateNormal];
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] forState :UIControlStateSelected];
}

edited Jul 26 '13 at 11:03

9to5ios

5,319
2
37
65

answered Jul 26 '13 at 10:37

He wanted to change it for both UIControlState selected and normal. You should call the method twice to add the image for these two control states. Also, you should give some explanation for this code and for what the user was doing wrong. – Ramy Al Zuhouri Jul 26 '13 at 10:42
yes it will work please check if you only want to change only for UIControlStateNormal it will work – Jul 26 '13 at 10:50
why dont you put forstate in second line? – KDeogharkar Jul 26 '13 at 10:55
oh it just syntax error please add this when you apply this code – Jul 26 '13 at 11:03

Rajneesh071 · Answer 4 · 2013-07-26T10:53:30.640

0

First check IBOutlet connection of your button :)

And set your code after getting data from web service i.e. after getting value of unread

if(unread>0){
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];
}
else{
    [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] forState:UIControlStateNormal];
}

edited Jul 26 '13 at 10:53

answered Jul 26 '13 at 10:29

Rajneesh071

30,846
15
61
74

and it is in "or" with UIControlStateNormal. and BTW with just only UIControlStateNormal it is not working – KDeogharkar Jul 26 '13 at 10:30
check IBOutlet connection of your button :) – Rajneesh071 Jul 26 '13 at 11:35
then make a new button from starting :) – Rajneesh071 Jul 26 '13 at 11:52
dude many time this will work to remove previous object and make new – Rajneesh071 Jul 26 '13 at 11:58

score 0 · Answer 5 · answered Jul 26 '13 at 10:29

0

[badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal|UIControlStateSelected];

are you adding the button image for UIControlStateNormal or UIControlStateSelected

try

[badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal];

find whether the image exist and added properly to the bundle and The name is correct

answered Jul 26 '13 at 10:29

Lithu T.V

19,955
12
56
101

image is exist @Lithu – KDeogharkar Jul 26 '13 at 10:36
@BaZinga try setting image in two lines for controlstate normal and selected – Lithu T.V Jul 26 '13 at 10:37
@BaZinga since you are setting foe selected do try setting image for unselected state – Lithu T.V Jul 26 '13 at 10:39

score 0 · Answer 6 · answered Jul 26 '13 at 10:39

0

Set background images for UIControlStateNormal and UIControlStateSelected as separate lines.

if(unread>0){

   [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] UIControlStateNormal];

   [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] UIControlStateSelected];
} else {

   [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] UIControlStateNormal];

   [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] UIControlStateSelected];
}

answered Jul 26 '13 at 10:39

Shamsudheen TK

30,739
9
69
102

Correct, but please at least add some explanation. – Ramy Al Zuhouri Jul 26 '13 at 10:40
same answer as above posted ! – 9to5ios Jul 26 '13 at 10:52

score 0 · Answer 7 · answered Jul 26 '13 at 11:16

0

UIButton *btn = [[UIButton alloc]init];
    btn.frame = CGRectMake(50, 50, 100, 50);
    [btn setTitle:@"ok" forState:UIControlStateNormal];
    [btn setBackgroundImage:[UIImage imageNamed:@"icon.png"] forState:UIControlStateNormal];
    btn.backgroundColor=[UIColor blueColor];

I hope this works for u....

answered Jul 26 '13 at 11:16

Maulik Kundaliya

452
3
17

try this, if(unread.text.length>0){ [badgeTitle setBackgroundImage:[UIImage imageNamed:@"unread.png"] forState:UIControlStateNormal]; } else{ [badgeTitle setBackgroundImage:[UIImage imageNamed:@"read.png"] forState:UIControlStateNormal]; } if unread is string then this is works... – Maulik Kundaliya Jul 26 '13 at 12:43

score 0 · Answer 8 · answered Jun 10 '14 at 14:36

0

after setting the background image

[badgeTitle setNeedsLayout];

answered Jun 10 '14 at 14:36

tdios

225
1
2
16

UIButton background image not changing

8 Answers8