Is it possible for a service to return a 404 response?

Question

Is there an exception or something else that can be raised from a service (or other non-Controller method) that will interrupt the current response handling and return a 404 to the user?

In the Django world, there is get_object_or_404 which raises a Http404 exception which has this effect. I'm writing service; if that service determines that the object requested is not accessible to the user (in this case it's not published yet), I would like it to trigger a 404 and stop the remainder of the execution. The goals is for the controllers calling the service to be DRY and not always repeat the def obj = someService.getSomething(); if (obj) {} else { render status: 404} call.

Summary:
In Django, I can raise a Http404 at any point to stop request processing and return a 404. Is there an equivalent or a way to do this in Grails NOT from a controller?

I'm not sure why you want to NOT return status code from controller? I mean, since the first time I begin with Java/Groovy, I was taught that it's the proper way to implement (service throws exception, controller catches and returns status code). Service should not know anything about request processing, and so does controller doesn't know anything about business logic? — Hoàng Long, Jul 30 '13 at 03:21

score 4 · Answer 1 · answered Jul 29 '13 at 23:19

4

In a controller, you can set the status of the response to any code you like.

    response.status = 404

You can also use render with a status - from the docs:

// render with status code
render(status: 503, text: 'Failed to update book ${b.id}')

You can have your controller that delegates to the service do this prior to calling the service method, or you can have your service return a status code to the controller.

answered Jul 29 '13 at 23:19

doelleri

19,232
5
61
65

1

I would rather suggest using `org.springframework.http.HttpStatus.NOT_FOUND.value` instead of 404 hardcoded. – dmahapatro Jul 29 '13 at 23:26
Yes, that's how you do it within a controller, but my question is how **not** to do it in a controller. I.e., from a service. I'm trying to be DRY and not repeat the check and render 404 in every controller. – smacintyre Jul 29 '13 at 23:42
I faced a issue, I called a service which is written in Groovy/Grails application. It exposes one rest service and I am calling it from other application. I am able to call the service using RestTemplate class of Spring but it return me bad request. Even I am sending it HTTP.OK as a response. I am not able to understnad why it is happening. But with the help of this post, I am able to solved it. Send the response as `code` render(status: 200, text: 'Success') `code` Thanks @doelleri for the answer. – Atul Mar 06 '19 at 06:25

score 4 · Accepted Answer · answered Jun 19 '14 at 13:55

Create an Exception class like com.my.ResourceNotFoundException and then throw it from whatever place you want (controller or service).

Create a controller like the one below:

class ErrorController {

    def error404() {
        response.status = HttpStatus.NOT_FOUND.value()
        render([errors: [[message: "The resource you are looking for could not be found"]]] as JSON)
    }
}

Then add into your UrlMappings.groovy configuration file an entry that will handle exceptions of that type with this controller action. Specifying "500" as the pattern means that it will catch 500 errors (like the one your thrown ResourceNotFoundException will cause) and if the exception matches that type it will use the controller and action specified.

"500"(controller: "error", action: "error404", exception: ResourceNotFoundException)

dmahapatro · Answer 3 · 2013-07-30T13:24:00.413

@doelleri has mentioned what can be done exactly for rendering status code.

A "not-so-groovier" way you can achieve DRYness in controller is shown below. But again if you want to move the try catch block to an utility you can achieve something more.

//Custom Exception
class CustomException extends Exception{
    Map errorMap

    CustomeException(Map map, String message){
        super(message)
        this.errorMap = map
    }
    ....
}

//service
def getSomethingGood(){
    ....
    ....
    if(something bad happened){
        throw new CustomException([status: HttpStatus.NOT_FOUND.value, 
                                   message: "Something really got messed up"], 
                                   "This is a custom Exception")
        //or just return back from here with bad status code 
        //and least required data
    }
    ......
    return goodObj
}

def getSomething(){
    def status = HttpStatus.OK.value
    def message
    try{
        def obj = getSomethingGood()
        message = "success value from obj" 
        //or can also be anything got from obj  etc
    } catch(CustomException c){
        status = c.errorMap.status
        message = c.errorMap.message
    }

    [status: status, message: message]
}

//controller
def obj = someService.getSomething()
render(status: obj.status, text: obj.message)

Also note, when you handle checked exceptions, transactions do not roll back in service layer. There is something else that has to be done, which I think is out of scope of this question.

Is it possible for a service to return a 404 response?

3 Answers3