MVC4 EF5 Changes not saved to DB

Question

My code looks like this: (where "user" is the UserProfile instance passed back from the view after being edited)

UserProfile original = DBContext.UserProfiles.Where(x => x.UserId == user.UserId).FirstOrDefault();
if (original != null)
{
   original = user;
   DAL.DAL.Instance.TGIMobiledb.SaveChanges();
}

This code fires without error, but does not update the DB. After some research it seems I have to add the following line before calling SaveChanges()

DBContext.Entry(original).State = EntityState.Modified;

But that line of code causes this error:
"An object with the same key already exists in the ObjectStateManager. The ObjectStateManager cannot track multiple objects with the same key."

The changes saves to the db fine if I assign every field manually like this:

original.UserId = user.UserId;
original.FirstName = user.FirstName;
original.Surname = user.Surname;
original.UserName = user.UserName;

Obviously this is less than optimal, especially with the larger entities.

Here http://stackoverflow.com/questions/15336248/entity-framework-5-updating-a-record is a good discussion on scenarios of updating entities in EF5. — juhan_h, Jul 30 '13 at 08:08

score 1 · Accepted Answer · answered Jul 30 '13 at 08:08

1

Try:

DBContext.Entry(original).CurrentValues.SetValues(user);

answered Jul 30 '13 at 08:08

haim770

48,394
7
105
133

Worked like a charm! Thanks haim! – Swifty Jul 30 '13 at 08:16

score 0 · Answer 2 · answered Jul 30 '13 at 08:09

I'm guessing you retrieve the user and check for null to see if you need to create or update it.

Instead, you can check the UserId field.

if (user.UserId == 0)
{
    DBContext.UserProfiles.Add(user);
}
else
{
    DBContext.UserProfiles.Attach(user);
    DBContext.Entry(user).State = EntityState.Modified;
}

MVC4 EF5 Changes not saved to DB

2 Answers2