Android if statement does not fire?

Question

Why does my "if" statement not fire?

String something = "";
String category = json_data.getString("den");
Log.e("JSON", "category="+category);            
if (category == "1"){
  something = "Random something";
}

Even if in my logcat I can see JSON:"category=1", the "something" String does not take "Random something" value. This must be some convention in java? Please help.

score 4 · Accepted Answer · edited May 23 '17 at 11:59

4

use:

if (category.equals("1")){
    something = "Random something";
}

or better way to avoid null pointer exception:

if ("1".equals(category)){
    something = "Random something";
}

Also have a look at this link for detail : How do I compare strings in Java?

edited May 23 '17 at 11:59

Community

1
1

answered Jul 31 '13 at 21:53

M-Wajeeh

17,204
10
66
103

Thank you. It's a strange syntax :) – user1137313 Jul 31 '13 at 22:05
1

@user1137313 No, not really. – Vikram Jul 31 '13 at 22:19

score 1 · Answer 2 · answered Jul 31 '13 at 21:53

1

You need to do string comparison in Java using the .equals method on the String object. The comparison you are doing is only comparing the references not the actual string values.

Example:

if(category.equals("1")){
    //do amazing stuff
}

answered Jul 31 '13 at 21:53

Ralph Caraveo

10,025
7
40
52

Android if statement does not fire?

2 Answers2