Google Maps marker.getPosition only uses last co-ords

Question

I'm importing map data from an XML list and placing that in markerArray, then calling createMarkers(); The markers appear on the map ok, but clicking always goes to the last marker on the list.

All help appreciated.

function createMarkers() {
for (i=0; i<markerArray.length; i++){
 var marker = new google.maps.Marker({position:markerArray[i].latlng, map:map, title:markerArray[i].label, icon:images[markerArray[i].type]});
 google.maps.event.addListener(marker, 'click', function() {
        map.setZoom(9);
  map.setCenter(marker.getPosition());
    }); 
}

Just a random thought: can you use map.setCenter(this.getPosition()); ? — Matthijs, Aug 01 '13 at 11:10

score 3 · Accepted Answer · answered Aug 01 '13 at 12:08

3

marker is redefined with each loop iteration. The function bound to 'click' should be wrapped in a closure with a local copy of marker. I had to do something similar once and used this:

 google.maps.event.addListener(marker, 'click', 
   (function(marker_inner) {
      return function() {
        map.setZoom(9);
        map.setCenter(marker_inner.getPosition());
      }
   })(marker)
 );

answered Aug 01 '13 at 12:08

giaour

3,878
2
25
27

That certainly works, as does (this.getPosition). The latter seems a more elegant solution, or am I missing something? – user2641761 Aug 01 '13 at 16:37
In the code I took the snippet above from, there was a bit more going on ... `this` is sufficient for what you're trying to do, but I guess I just like closures ;) – giaour Aug 01 '13 at 17:16
Thanks. Does this also work for infoWindow data? – user2641761 Aug 01 '13 at 17:42
Use the closure method for setting infoWindow data. – giaour Aug 01 '13 at 17:44

Google Maps marker.getPosition only uses last co-ords

1 Answers1