Onclick statement doesn't show up

Question

I'm writing a chrome extension, and I'm trying to add a link that calls a javascript function, exactly like in the question.

However, when I click the link, nothing happens - and when I look at the debug console, the "a" node doesn't have an "onclick" property at all, it just looks like this:

<a href="#">Add to likes</a>

This is my code:

function generateEntry(innerEntry) {    
    var a = document.createElement('a');
    var linkText = document.createTextNode("Add to likes");
    a.appendChild(linkText);
    a.onclick="addToLikes('" + "hello" + "')"
    a.href = "#";
    return a
}

If I manually add the "onclick" declaration in the debug console, everything works.

<a href="#" onclick="addToLikes('hello2')">Add to my likes</a>

What's wrong with my script?

score 0 · Answer 1 · edited Aug 01 '13 at 12:27

0

you have to use the function for onclick

function generateEntry(innerEntry) {    
    var a = document.createElement('a');
    var linkText = document.createTextNode("Add to likes");
    a.appendChild(linkText);
    //a.onClick="addToLikes('" + "hello" + "')"
    a.onclick = function () {
    addToLikes('hello2');
    };
    a.href = "#";
    return a
}

edited Aug 01 '13 at 12:27

Yossale

14,165
22
82
109

answered Aug 01 '13 at 12:14

Mirko Cianfarani

2,023
1
23
39

Perfect, you can put my answer how helpful's answer please – Mirko Cianfarani Aug 01 '13 at 12:33

score 0 · Answer 2 · answered Aug 01 '13 at 12:18

0

The onclick property takes a function as its value, not a string.

function addHelloToLikes() {
    addToLikes("hello");
}

a.onclick = addHelloToLikes;

You may wish to use, the more modern, addEventListener method instead.

answered Aug 01 '13 at 12:18

Quentin

914,110
126
1,211
1,335

I've copied it from google scholar results page - maybe it's something I don't get?: Cite – Yossale Aug 01 '13 at 12:23
1

@yossale — That's an HTML attribute, not a JavaScript property assignment. – Quentin Aug 01 '13 at 12:25

Onclick statement doesn't show up

2 Answers2