Javascript function need allow numbers, dot and comma

Question

I need to create a function to allow numbers dot and comma. So anyone corrects the following function

function on(evt) {
  var theEvent = evt || window.event;
  var key = theEvent.keyCode || theEvent.which;
  key = String.fromCharCode( key );
  var regex = /[0-9]|\./;
  if( !regex.test(key) ) {
    theEvent.returnValue = false;
    if(theEvent.preventDefault) theEvent.preventDefault();
  }
}

score 46 · Accepted Answer · answered Aug 03 '13 at 12:57

46

Firstly your regex currently doesn't allow comma, which is your requirement.

Secondly, you haven't used any quantifier, so your regex will match only a single character - one of [0-9] or a dot. You need to use a quantifier.

Thirdly, instead of using pipe, you can move all characters inside the character class only.

Try using the below regex:

/^[0-9.,]+$/

Quantifier + is used to match 1 or more occurrence of the pattern.
^ and $ anchors match the beginning, and end of the string respectively.

answered Aug 03 '13 at 12:57

Rohit Jain

209,639
45
409
525

2

Is there a way to limit only one dot or one comma? In your regex, 12.34,45 is correct – Seb Gy Jul 04 '16 at 14:10
I assume that for the most cases we have to use `/^[0-9.,]*$/` – NoWar Apr 24 '19 at 06:59

Niet the Dark Absol · Answer 2 · 2013-08-03T13:09:53.747

No need for JavaScript:

<input type="text" pattern="[0-9.,]+" title="Please enter a valid decimal number." />

Modern browsers will handle this perfectly.

If you want to specifically allow commas as thousand separators and a single decimal point, try this:

... pattern="\d{1,2}(,\d{3})*(\.\d+)?" ...

Note that I am firmly against blocking user input. They should be able to type what they want, and then told if they enter something invalid.

score 6 · Answer 3 · edited May 23 '17 at 12:02

6

Your regex is incorrect.

var regex = /^[0-9.,]+$/;

Regex javascript, why dot and comma are matching for \

https://stackoverflow.com/tags/regex/info

edited May 23 '17 at 12:02

Community

1
1

answered Aug 03 '13 at 12:59

HIRA THAKUR

17,189
14
56
87

Martin · Answer 4 · 2013-11-14T10:11:00.053

This is the best solution, in my opinion, covers more cases of inputs and allow floats.

     $( ".numerical" ).on('input', function() { 
                var value=$(this).val().replace(/[^0-9.,]*/g, '');
                value=value.replace(/\.{2,}/g, '.');
                value=value.replace(/\.,/g, ',');
                value=value.replace(/\,\./g, ',');
                value=value.replace(/\,{2,}/g, ',');
                value=value.replace(/\.[0-9]+\./g, '.');
                $(this).val(value)

        });

score 1 · Answer 5 · answered Apr 13 '16 at 06:39

1

Sometimes /^[0-9.,]+$/ is not work If not, then you could do something like this:

/^(?:[\d-]*,?[\d-]*\.?[\d-]*|[\d-]*\.[\d-]*,[\d-]*)$/

answered Apr 13 '16 at 06:39

Sanjib

11
1

this not allowed to use negative numbers. – ncubica Nov 01 '17 at 20:05
This one works great for decimals and periods! Thanks! – Scott Yu - builds stuff Jul 18 '18 at 18:40

score 0 · Answer 6 · edited Oct 26 '18 at 08:07

0

The Regex that I made for numbers following format of COMMA9.2

Example

1,350.88
120.00
1,500,999.24
100
10000000

RegEx

^(\d+|\d{1,3},\d{3}|\d{1,3},\d{3},\d{3}|\d{1,3}(,\d{3})*|\d{1,3}(,\d{3})*\.\d+)$

edited Oct 26 '18 at 08:07

Dov Benyomin Sohacheski

7,133
7
38
64

answered Oct 26 '18 at 07:07

gaurav gupta

151
1
3
11

Javascript function need allow numbers, dot and comma

6 Answers6

Linked

Related