Comparing String to String is not working

Question

I have this code and to me it seems like the logic is correct. When the value.toString() is entered it prints out 0123456789 just like it should because that is the value I entered in the editText field. Is there something simple that I am missing here or is this fine and I will have to look further afield.

Editable value = input.getText();
Log.i("Password entered: ", value.toString());
if(value.toString() == "0123456789"){
    Log.i("Password entered: ", "yay it is working!");
} else {
    Log.i("Password entered: ", "it is incorrect");
}

score 8 · Accepted Answer · answered Aug 05 '13 at 03:38

8

Use .equals to compare strings.

     if(value.toString().equals("0123456789"))

answered Aug 05 '13 at 03:38

Raghunandan

132,755
26
225
256

Thank you so much! I feel like an idiot now! We all learn something new every day! – Nick Aug 05 '13 at 03:39
@Nicholas yup happens to all. use can also use `.equalsIgnoreCase`. – Raghunandan Aug 05 '13 at 03:42
Thanks, I will definitely keep that in mind now :) – Nick Aug 05 '13 at 03:43
Sorry I was waiting for the 15 min to count down :) – Nick Aug 05 '13 at 03:59

score 1 · Answer 2 · answered Aug 05 '13 at 03:40

1

== tests for reference equality.

.equals() tests for value equality.

value.toString().equals("0123456789")

will work as intended.

answered Aug 05 '13 at 03:40

Akinakes

657
4
10

score 0 · Answer 3 · answered Aug 05 '13 at 04:10

0

You can compare Your String with Following Code

value.toString().equalsIgnoreCase("0123456789");

It gives you best result.

answered Aug 05 '13 at 04:10

Sanket Shah

4,352
3
21
41

score -1 · Answer 4 · answered Aug 05 '13 at 04:23

-1

Try this:

((value.toString()).compareTo("0123456789") == 0){
     //Do somthing here
}

answered Aug 05 '13 at 04:23

Long Dao

1,341
4
15
33

This is more unreadable than .equals() and should only be used if one is really interested in the order of the strings, but not if just checking for equality. – Bananeweizen Aug 05 '13 at 04:39
In my opinion, it is much stronger to compare 2 strings than the equals() method. I can't see why you said it is unreadable??? – Long Dao Aug 05 '13 at 04:44
It is unreadable, because everyone maintaining that code will have to "decode" the part "compareTo(...) == 0" meaning "equals". While with the solution using "equals()" you can read the code like English literature. Also it is quite easy to write "compareTo(...) != 0" or "compareTo(...) < 0" or something else by mistake and not notice that. For the "equals(...)" call that is basically impossible. Therefore this will avoid more bugs in the long run. – Bananeweizen Aug 05 '13 at 04:54

Comparing String to String is not working

4 Answers4