asp.net button event not firing

Question

I have a problem. While I am adding an event handler from code behind to a button the event never gets fired. But when I add it from when creating the button tag it works perfectly and I am creating the button from code behind and I adding it to table.

<form id="form1" runat="server">
    <div>                       
        <asp:Button ID="Button1" runat="server" Text="show table" OnClick="Button1_OnClick" />
        <table border="1">
            <thead>
                <tr>
                </tr>
            </thead>
            <tbody id="tbody" runat="server">

            </tbody>
        </table>
    </div>
</form>


protected void Button1_OnClick(object sender, EventArgs e)
{
  var row = new TableRow(); 
  var btnDownload = new Button { ID = "ID", Text = "Click Here" };
  btnDownload.Click += ClickEvent;
  var cell = new TableCell();
  cell.Controls.Add(btnDownload);
  row.Controls.Add(cell);
  tbody.Controls.Add(row);
}
protected void ClickEvent(object sender, EventArgs e)
{
  Debug.WriteLine(((Button)sender).Text);
}

score 8 · Answer 1 · edited May 23 '17 at 12:25

Please don't accept this as the answer, chappoo answered your question.

Since an event is fired one time, your control will exist just once and will disappear on next PostBack. You shouldn't create/delete controls in a PostBack event. Dynamic server controls must be created during the Init of the page.

Here are some links to understand ASP.NET and ASP.NET MVC 'life cycles'.

ASP.NET

You can see that any controls must exist during the Load of the page to raise the control events (RaiseChangedEvents) and post back events (RaisePostBackEvent). For example, page child controls -and controls sub-controls- are created (CreateChildControls), data-binded (after OnPreRender) and rendered (RenderControl) AFTER the page Load. Sometimes, some developers call the EnsureChildControls in the page Load to pre-load the child controls.

http://msdn.microsoft.com/en-us/library/ms178472.aspx ASP.NET Page LifeCycle

ASP.NET MVC

'Life cycle' is purely for request processing. Actions (Controller) are rendering (View) independent.

ASP.Net MVC - Request Life Cycle

http://www.red-gate.com/products/dotnet-development/ants-performance-profiler/entrypage/be-ahead-of-the-game-poster1 ASP.NET MVC 'life cycle'

Thanks for providing this good explanation & sharing informative links. — Tvd, Apr 03 '15 at 10:26

score 5 · Accepted Answer · answered Aug 08 '13 at 08:05

5

The answer to this question lies in understanding the ASP.NET page lifecycle. ASP.NET reconstructs a server instance of the page on postback. Once the server is done processing and the response is sent back to the client, the server instance is destroyed forever, and can only be recreated using a combination of the data contained in the browser (view data / cookies etc) and remaining server data (session / cache).

You're wiring up the click event of the dynamic button in the Button1_OnClick event handler. When ASP.NET tries to reconstruct the page on the next postback, it will not run this event handler (as Button1 wasn't clicked) so the event handler will never be wired up, explaining why it never runs. You need to wire any event handlers in or before the Page_Load handler in order to capture control event handlers.

answered Aug 08 '13 at 08:05

SteveChapman

3,051
1
22
37

I am going to use Jquery ajax it is much easier to implement client event. – danarj Aug 08 '13 at 08:55
1

That's probably a better option. If you have the choice, I'd also recommend doing any new development using the ASP.NET MVC framework (or similar) in favour of Web Forms. It's pretty much outdated now (that's a personal opinion). – SteveChapman Aug 08 '13 at 10:20
I definitely would learn & use ASP.NET MVC because it is newer and web form suck thank you – danarj Aug 08 '13 at 11:23

asp.net button event not firing

2 Answers2