I'm trying to append a character array to the string leaving the string intact with operator overloading+

Question

This is my code.. is giving me a warning saying that 'str' reference to stack memory associated with local variable 'str' returned... Also, I wanna be sure that my logic is good or if there a simpler way to way, I will really appreciate some help to learn more ways.. Thanks!

void CopyString(char *s)
{
    delete szArr;
    if (s)
    {
        szArr = new char[strlen(s)+1];
        strcpy(szArr,s);
    }
    else
    {
        szArr = new char[1];
        szArr[0]=0;
    } 
}


MyString& operator+(char *s){
    if (!s)
        return *this;
    char *tmp=new char[strlen(szArr)+strlen(s)+1];
    strcpy(tmp, szArr);
    strcat(tmp, s);
    MyString str(tmp);
    delete tmp;
    return str;
}

You're not using the right form of `delete` and your `operator+` should really be implemented in terms of `operator+=`. You should also not restrict a parameter that you don't change to being non-const. You're also copying `szArr`, then overwriting it with `s`. — chris, Aug 08 '13 at 23:25
This particular probelem is solved by A.E. Drew's answer below, but a million bucks says there are a lot more problems with the code we're not seeing. — Benjamin Lindley, Aug 08 '13 at 23:28

score 2 · Accepted Answer · answered Aug 08 '13 at 23:25

2

You are returning a reference to str which is a local variable in your function.

Return a copy: MyString operator+(char *s).

answered Aug 08 '13 at 23:25

A.E. Drew

2,097
1
16
24

score 0 · Answer 2 · answered Aug 08 '13 at 23:44

0

Another minor fault is strcpy(tmp, s) which is not correct.Change strcpy to strcat may be right.

answered Aug 08 '13 at 23:44

user1844934

1
1
1

Thanks, I already fix that. – JV17 Aug 09 '13 at 00:18

I'm trying to append a character array to the string leaving the string intact with operator overloading+

2 Answers2