Listview item with button random selection while scrolling

Question

I'm facing strange selection of list-view item while scrolling.

Initial selection screenshot(selected 1st entry) enter image description here

after scrolling listview item is auto selected why? (see below screenshot)

enter image description here

adapter source code is here

public View getView(int position, View convertView, ViewGroup parent) {
    View vi=convertView;
    if(convertView==null)
        vi = inflater.inflate(R.layout.list_row, null);

    TextView title = (TextView)vi.findViewById(R.id.title); // title
    TextView artist = (TextView)vi.findViewById(R.id.artist); // artist name
    TextView duration = (TextView)vi.findViewById(R.id.duration); // duration
    ImageView thumb_image=(ImageView)vi.findViewById(R.id.list_image); // thumb image

    HashMap<String, String> song = new HashMap<String, String>();
    song = data.get(position);

    // Setting all values in listview
    title.setText(song.get(CustomizedListView.KEY_TITLE));
    artist.setText(song.get(CustomizedListView.KEY_ARTIST));
    duration.setText(song.get(CustomizedListView.KEY_DURATION));
    imageLoader.DisplayImage(song.get(CustomizedListView.KEY_THUMB_URL), thumb_image);
    return vi;
}

make button visible in setonitemclicklistner() is giving the problem

list.setOnItemClickListener(new OnItemClickListener() {

@Override
public void onItemClick(AdapterView<?> parent, View view,
        int position, long id) {
list.setOnItemClickListener(new OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view,
        int position, long id) {
view.setSelected(true);
view.setBackgroundResource(R.drawable.gradient_bg_hover);   
TextView title;
TextView artist;
title = (TextView)view.findViewById(R.id.title); // title
artist = (TextView)view.findViewById(R.id.artist); // artist
title.setTextColor(getResources().getColor(android.R.color.white));
artist.setTextColor(getResources().getColor(android.R.color.white));

ImageButton btnChild = (ImageButton)view.findViewById(R.id.arrow);
btnChild.setVisibility(View.VISIBLE);

if(lastselected!= null)
{

    title = (TextView)lastselected.findViewById(R.id.title); // title
    artist = (TextView)lastselected.findViewById(R.id.artist); // artist
    title.setTextColor(getResources().getColor(android.R.color.black));
    artist.setTextColor(getResources().getColor(android.R.color.black));

     btnChild = (ImageButton)lastselected.findViewById(R.id.arrow);
    btnChild.setVisibility(View.INVISIBLE);
    lastselected.setBackgroundResource(R.drawable.gradient_bg);
}

lastselected= view;

after image button is visible the getview recycle the same view for next displaying item. I don’t know how to fix this.

http://stackoverflow.com/questions/2907335/android-disabling-highlight-on-listview-click — Ankur Aggarwal, Aug 12 '13 at 08:52
@ankur: my problem is not about disabling color. its to avoid auto selection of listitem while scrolling. — user755, Aug 12 '13 at 08:54
I did read that post. the listview behaviour is not same as described to what I posted above. — user755, Aug 12 '13 at 12:22

score 1 · Answer 1 · answered Aug 12 '13 at 11:06

1

use

listview.setSelector(drawable)

if you want to change selector or disable it.

answered Aug 12 '13 at 11:06

ali shekari

740
1
11
26

score 0 · Answer 2 · answered Aug 12 '13 at 08:56

0

You can use an onScrollListener to detect when the list is scrolling and prevent an item being selected.

Have a look here (click).

onScroll()

Callback method to be invoked when the list or grid has been scrolled. This will be called after the scroll has completed

onScrollStateChanged()

Callback method to be invoked while the list view or grid view is being scrolled. If the view is being scrolled, this method will be called before the next frame of the scroll is rendered.

answered Aug 12 '13 at 08:56

Scott Helme

4,786
2
23
35

Its scroll listeners. which are working fine.. the issue is when list item is autoselected... which has nothing to do with scrolling. – user755 Aug 12 '13 at 09:02
Apologies, I misunderstood the question I think. – Scott Helme Aug 12 '13 at 09:20

score 0 · Answer 3 · answered Aug 12 '13 at 09:02

0

This is a common pitfall with adapter getView(). When a view is recycled (convertView is not null), you will need to reset the recycled view to its initial state. In this case, reset the checked/selected state of the recycled list row.

answered Aug 12 '13 at 09:02

laalto

150,114
66
286
303

yes.I implemented like 'if(isSelected[position]== true) { vi.setSelected(true); } else { vi.setSelected(false); }' But still same issue – user755 Aug 12 '13 at 09:07
you are right! list has a invisible button when user selects the listitem I make the button visible inside setOnItemClickListener() and this change is being recycled inside getview. any clues how to proceed? – user755 Aug 12 '13 at 13:44

score 0 · Answer 4 · edited May 23 '17 at 10:31

0

Try this:

Selected Item issue while scrolling listview

Because of lazy loading, the states of the views are not guaranteed. It would be much more precise if you store an extra boolean, or in your case another another pair of strings to your HashMap if it's easier, to flag whether the song was selected. Implementing ViewHolders won't hurt as well. Hope this helps.

edited May 23 '17 at 10:31

Community

1
1

answered Aug 12 '13 at 09:07

donkey

204
1
7

Listview item with button random selection while scrolling

4 Answers4