What's wrong with my PHP Script? T_String issue

Question

I'm just trying to get some data through a table in a specific row.

Here's my script.

<?php
$con=mysqli_connect("localhost","root","","astralms");

if (mysqli_connect_errno())
  {
  echo "Failed to connect to MySQL: " . mysqli_connect_error();
  }

$type = htmlspecialchars(mysql_real_escape_string($_GET['type']));
$username = htmlspecialchars(mysql_real_escape_string($_GET['username']));

$result = mysqli_query($con,"SELECT * FROM accounts
 WHERE name = '%s', $username);

while($row = mysqli_fetch_array($result))
  {
    if($type == "nxcash") {
    echo $row['ACash'];
    } else if($type == "votepoints") {
    echo $row['vpoints'];
    } else if ($type == "gmlevel") {
    echo $row['gm'];
   }
  }
?>

However, I get:

( ! ) Parse error: syntax error, unexpected 'nxcash' (T_STRING) in C:\wamp\www\accountdata.php on line 17.

when using it like 127.0.0.1/accountdata.php?username=tester&type=votepoints

Thanks.

I think StackOverflow text highlighting script has already answered your question :) — Lim H., Aug 12 '13 at 12:11
Missing quote in `"SELECT * FROM accounts WHERE name = '%s', $username` put `"` after this. — PiLHA, Aug 12 '13 at 12:11

score 2 · Answer 1 · answered Aug 12 '13 at 12:10

2

You are missing a ":

 WHERE name = '%s', $username);
//                ^-- there

Most IDEs will be able to pick out syntax error. I'd recommend investing some time getting familiar with a good one. There are free ones too.

answered Aug 12 '13 at 12:10

Halcyon

57,230
10
89
128

glad to see it fixed :) – sevenseacat Aug 12 '13 at 12:13

score 0 · Answer 2 · answered Aug 12 '13 at 12:10

0

You missed a closing double quote on your SQL query, after WHERE name = '%s'.

answered Aug 12 '13 at 12:10

sevenseacat

24,699
6
63
88

score 0 · Answer 3 · answered Aug 12 '13 at 12:11

0

Line 12/13.

$result = mysqli_query($con,"SELECT * FROM accounts WHERE name = '%s', $username);

It is missing a quotation speechmark.

answered Aug 12 '13 at 12:11

http://puu.sh/406Ai.png still error. – user2674867 Aug 12 '13 at 12:13

Scott Helme · Answer 4 · 2013-08-12T12:18:22.613

0

The syntax highlighting right here on SO has highlighted your error:

This:

$result = mysqli_query($con,"SELECT * FROM accounts WHERE name = '%s', $username);

Should be this:

$result = mysqli_query($con,"SELECT * FROM accounts WHERE name = '%s'", $username);

Notice the close quotes -------------------------------------------------------------------- here -----^

edited Aug 12 '13 at 12:18

answered Aug 12 '13 at 12:12

Scott Helme

4,786
2
23
35

that's not where the closing quote goes. See the other answers. – sevenseacat Aug 12 '13 at 12:16
Derp, you're right! More coffee needed... Answer updated, thanks :-) – Scott Helme Aug 12 '13 at 12:17

What's wrong with my PHP Script? T_String issue

4 Answers4