Stop program when thread finished

Question

I'm a newbie in C#. I have a windows service. In this service, I run a thread. I want to stop the service immediately after the thread finish. Currently, my code is like:

while(true){
     if(isThreadFinished){
          MyService.Stop();
          break;
     }
}

It work, but I feel that using while(true) like that is a stupid way. So, I want to know if there is any other way to achieve my request.

@Shane.C because CPU usage will skyrocket for no good reason this way. — Andrew Savinykh, Aug 14 '13 at 09:39
Its not a stupid way per say but it will involve a lot of processing, you may wish to use a timer instead and only check if the thread is finished after X ammount of milliseconds — Sayse, Aug 14 '13 at 09:41
@Shane.C When i debugging, I see that the program have to run both thread and while(true)... at the same time, so, if the thread have to run in a long time, i'm afraid that it will slow down my program. — user2500561, Aug 14 '13 at 09:42
Why you can´t ust call MyService.Stop as a last step in the execution thread? — ne2dmar, Aug 14 '13 at 09:45
Of course it's st.. inappropriate. One core and memory-bandwidth down the drain. — Martin James, Aug 14 '13 at 09:51
What happens if you call 'ExitProcess(0)' as the last line of the thread code? — Martin James, Aug 14 '13 at 09:56
@ne2dmar;Martin James: Oh sh.t, sometime I feel so stupid, thanks u! — user2500561, Aug 14 '13 at 10:00

score 1 · Answer 1 · answered Aug 14 '13 at 09:48

1

bool x=true;
while(x==true){
 if(isThreadFinished){
      x=false;
      MyService.Stop();
      break;
 }
}

answered Aug 14 '13 at 09:48

Super Hornet

2,839
5
27
55

break will exit the loop, the rest of the padding is irrelevant – Sayse Aug 14 '13 at 09:56

score 0 · Answer 2 · answered Aug 14 '13 at 09:43

I don't know C#, but usually you would have an API thread.join() or similar which waits for the thread to finish.

If nothing else you can block on the same synchronised object.

In Java, there's also Object.wait() and Object.notify() that does the trick.

score 0 · Accepted Answer · answered Aug 14 '13 at 09:48

And Why don't use the delegate? You have a sample and the documentation here , in the official MSDN website...

You just call you're delegate method before the end of your Thread...

That's more proprely that a while loop... and more optimize if your thread during a long time...

Stop program when thread finished

3 Answers3

Linked