Undefined Index error. Whats wrong in this?

Question

Need some help with a simple php code. When I try to access http://example.com/login.php, it gives me a warning "Notice: Undefined index: type in www.example.com on line 2". But, when Try to access http://example.com/login.php?type=InvalidLogin, everything works fine. Whats wrong in my code.

My Code:

<?
$type = $_REQUEST["type"];
if ($type == 'InvalidLogin') {
?>
Your login is invalid.

<?
} else {
?>
Your login is valid
<?
}
?>

There is 1830 results for [Notice: Undefined Index](http://stackoverflow.com/search?q=Notice%3A+Undefined+index+%5Bphp%5D) in addition to the thousand of results a search engine will give you. I don't see anything in your question that warrants asking this yet another time. Please do research before asking questions. — Gordon, Aug 19 '13 at 08:27

score 2 · Accepted Answer · answered Aug 19 '13 at 08:21

2

Try and do the following:

<?php
  if(isset($_GET["type"]))
  {
     $type = $_GET["type"];
     if ($type == 'InvalidLogin') {
        echo "Your login is invalid.";
     } 
  }
  else
  {
    echo "Your login is valid";
  }

?>

answered Aug 19 '13 at 08:21

Conrad Lotz

8,200
3
23
27

because http://stackoverflow.com/questions/2142497/whats-wrong-with-using-request – allen213 Aug 19 '13 at 08:23

score 1 · Answer 2 · answered Aug 19 '13 at 08:20

1

$_REQUEST["type"]

is requesting data from url http://example.com/login.php?type=InvalidLogin. If there isn't type, it gets error cannot find 'type'.

And dont use $_REQUEST to get the data. use $_POST or $_GET

answered Aug 19 '13 at 08:20

Namal

2,061
3
18
26

no use $_GET in this instance, its from a query string – allen213 Aug 19 '13 at 08:20
@allen213 $_GET can use for query strings. Isn't it? – Namal Aug 19 '13 at 08:23
Question implies us of a query string and $_GET is for that. – allen213 Aug 19 '13 at 08:24

score 0 · Answer 3 · answered Aug 19 '13 at 08:18

0

you should use isset ($_REQUEST["type"]) to test the index

answered Aug 19 '13 at 08:18

Gefferey Zhang

95
2
9

Undefined Index error. Whats wrong in this?

3 Answers3