C# Program that converts decimal number to binary

Question

So, I have to make a program that converts a decimal number to binary and prints it, but without using Convert. I got to a point where I can print out the number, but it's in reverse(for example: 12 comes out as 0011 instead of 1100), anyone has an idea how to fix that ? Here's my code:

        Console.Write("Number = ");
        int n = int.Parse(Console.ReadLine());
        string counter = " ";


        do
        {

            if (n % 2 == 0)
            {                  
                counter = "0";
            }

            else if (n % 2 != 0)
            {
                 counter = "1";
            }

            Console.Write(counter);

            n = n / 2;
        }
        while (n >= 1);

You could [reverse the string](http://stackoverflow.com/questions/228038/best-way-to-reverse-a-string) — tnw, Aug 22 '13 at 20:59

Jonesopolis · Accepted Answer · 2013-08-22T21:06:35.387

1

simple solution would be to add them at the beginning:

Console.Write("Number = ");
int n = int.Parse(Console.ReadLine());
string counter = "";

while (n >= 1)
{
   counter = (n % 2) + counter;
   n = n / 2;
}
Console.Write(counter);

You actually don't even need the if statement

edited Aug 22 '13 at 21:06

answered Aug 22 '13 at 21:00

Jonesopolis

25,034
12
68
112

score 0 · Answer 2 · answered Aug 22 '13 at 21:01

0

Instead of write them inmediately you may insert them in a StringBuidler

var sb = new StringBuilder();
....
sb.Insert(0, counter);

And then use that StringBuilder

var result = sb.ToString();

answered Aug 22 '13 at 21:01

OscarRyz

196,001
113
385
569

score 0 · Answer 3 · answered Aug 22 '13 at 21:01

0

You can reverse the String when you finish calculating it

answered Aug 22 '13 at 21:01

nonamer92

1,887
1
13
24

string counter ; // your number char[] inputarray = input.ToCharArray(); Array.Reverse(inputarray); counter = new string(inputarray); – nonamer92 Aug 22 '13 at 21:02

score 0 · Answer 4 · answered Aug 22 '13 at 21:14

You are generated the digits in the reverse order because you are starting with the least significiant digits when you use % 2 to determine the bit value. What you are doing is not bad though, as it is convenient way to determine the bits. All you have to do is reverse the output by collecting it until you have generated all of the bits then outputing everything in reverse order. ( I did not try to compile and run, may have a typo)

One easy solution is

System.Text.StringBuilder reversi = new System.Text.StringBuilder();

Then in your code replace

Console.Write(counter);

with

reversi.Append(counter);

Finally add the end of your loop, add code like this

string s = reversi.ToString();
for (int ii = s.Length-1; ii >= 0; --ii)
{
  Console.Write(s[ii]);
}

There are better ways to do this, but this is easy to understand why it fixes your code -- It looks like you are trying to learn C#.

score 0 · Answer 5 · answered Mar 18 '16 at 07:25

0

If I'm not mistaken

int value = 8;
string binary = Convert.ToString(value, 2);

answered Mar 18 '16 at 07:25

uzay95

16,052
31
116
182

C# Program that converts decimal number to binary

5 Answers5