Java String operation - Writing efficient code

Question

First of all, I am not a experienced java developer. The problem is My sql query give return data like this ABC BCD DEF EFG. But, I want to add , after the every entry So, I was tried with this

if (cursor != null) {
            cursor.moveToFirst();
            do {

                if (cursor.getPosition() == 0) {

                    getName = cursor.getString(cursor.getColumnIndexOrThrow("NAME"));

                } else {

                    getName = getName + ","
                            + cursor.getString(cursor.getColumnIndexOrThrow("NAME"));
                }

            } while (cursor.moveToNext());
        }

My question is is it okay or is there any way to write this code efficiently(Like achiving the same goal by writing less line of code). Thank you.

Isn't that code doing the opposite of what you actually want? — Rohit Jain, Aug 28 '13 at 16:15
I mean, your code currently will add comma after all the elements except the first. But you want the opposite. Add comma only after first element. Check to see whether your current code is working fine. — Rohit Jain, Aug 28 '13 at 16:18
@RohitJain May be you didn't get me. Please check my last comment. That's the format I want. — user2579475, Aug 28 '13 at 16:19
Then check your first two statements. You said, you want `,` after the first entry - `ABC`. — Rohit Jain, Aug 28 '13 at 16:19

Pete B. · Answer 1 · 2013-08-28T16:55:30.687

1

How about this:

myString = "ABC BCD DEF EFG";
String newString = myString.replace(" ", ", ");
System.out.println(newString);

Output:

ABC, BCD, DEF, EFG

edited Aug 28 '13 at 16:55

answered Aug 28 '13 at 16:17

Pete B.

3,188
6
25
38

1

Reading his comments, I think he would want `replaceAll`, but this is the best answer to achieve what he's asking for IMO so +1 – StormeHawke Aug 28 '13 at 16:28
I think the 'ABC','BCD' etc are just examples. The actual string may contain spaces that shouldn't be replaced. – Moob Aug 29 '13 at 08:26

score 0 · Answer 2 · edited May 23 '17 at 11:49

0

How about including the comma using the MySql query itself? You can find more about it in this link.

edited May 23 '17 at 11:49

Community

1
1

answered Aug 28 '13 at 16:19

Ramesh

765
7
24
52

score 0 · Answer 3 · answered Aug 28 '13 at 16:20

The following code would be shorter and should achieve the exact same thing you posted.

if (cursor != null) {
    cursor.moveToFirst();
    getName = cursor.getString(cursor.getColumnIndexOrThrow("NAME"));
    while (cursor.moveToNext()) {
        getName = getName + "," + cursor.getString(cursor.getColumnIndexOrThrow("NAME"));
    }
}

score 0 · Answer 4 · answered Aug 28 '13 at 16:22

0

How about-

String str = "ABC BCD DEF EFG";
str = str.replaceFirst(" ", ", ");
System.out.println(str);

Output:

ABC, BCD DEF EFG

answered Aug 28 '13 at 16:22

Sajal Dutta

18,272
11
52
74

score 0 · Answer 5 · answered Aug 28 '13 at 16:23

You can do it in less code but its probably no more efficient:

if (cursor != null) {
    cursor.moveToFirst();
    while(cursor.moveToNext()) {
        getName += ((!"".equals(getName))?",":"") + cursor.getString(cursor.getColumnIndexOrThrow("NAME"));
    } 
}

Depending on your requirements you could use a concat in the actual query.

score 0 · Answer 6 · answered Aug 28 '13 at 16:23

Your code will be a bit more efficient if you use StringBuilder rather than String when building up your result.

StringBuilder str = new StringBuilder();
loop...
    if (first) {
        str.append(cursor.getString(...));
    } else {
        str.append(',');
        str.append(cursor.getString(...));
    }
String theString = str.toString();

Every time you use + with strings, behind the scene you are creating temporary objects that need to be garbage collected. By explicitly using a StringBuilder you completely avoid extra objects to build your string in each iteration of your loop.

score 0 · Answer 7 · answered Aug 28 '13 at 16:47

0

I would like to point out one issue in your code ( not related to the string formatting ). When the cursor points to the first record, you should always check for null.

if (cursor.moveToFirst() != null)
{
    ...
}

answered Aug 28 '13 at 16:47

sjdutta

376
1
5

Java String operation - Writing efficient code

7 Answers7