Python oneline switch

Question

I am looking for a more elegant way to do the following:

py_loglevel = logging.DEBUG
if self.loglevel == "INFO":
   py_loglevel = logging.INFO
elif self.loglevel == "WARNING":
   py_loglevel = logging.WARNING
elif self.loglevel == "ERROR":
   py_loglevel = logging.ERROR

This works of couse, but it somehow annoys me because it is cluttering my code and is attracting my attention even though it is really trivial. Can this be done in a oneliner?

Upvoted for your effort to write elegant code :) – thefourtheye Aug 29 '13 at 10:07 — thefourtheye, Aug 29 '13 at 10:07

score 9 · Accepted Answer · answered Aug 29 '13 at 09:48

9

Use a dictionary:

levels = {
    'INFO': logging.INFO, 
    'WARNING': logging.WARNING,
    'ERROR': logging.ERROR,
}
py_loglevel = levels.get(self.loglevel, logging.DEBUG)

Alternatively, look up the name as an attribute on the module:

py_loglevel = getattr(logging, self.loglevel, logging.DEBUG)

provided the names match those defined on the module.

answered Aug 29 '13 at 09:48

Martijn Pieters

1,048,767
296
4,058
3,343

Ah, the simplicity... But you are stealing answers from @User. – RickyA Aug 29 '13 at 09:54
@Marijn Pieters: Ok you where the first so you get my vote ;) Are you Dutch btw? – RickyA Aug 29 '13 at 09:57

score 5 · Answer 2 · answered Aug 29 '13 at 09:48

5

py_loglevel = getattr(logging, self.loglevel)

answered Aug 29 '13 at 09:48

User

14,131
2
40
59

Really elegant 'if names match'. – RickyA Aug 29 '13 at 09:55

score 1 · Answer 3 · edited May 23 '17 at 12:05

1

see this, a bad way is:

py_loglevel = logging.DEBUG
py_loglevel = (logging.INFO if self.loglevel == "INFO" else(logging.WARNING self.loglevel == "WARNING") else logging.ERROR)
print ":D"

edited May 23 '17 at 12:05

Community

1
1

answered Aug 29 '13 at 09:54

Vahid Kharazi

5,723
17
60
103

2

Considered that but indeed to awful. – RickyA Aug 29 '13 at 09:56

Python oneline switch

3 Answers3