Count something FROM database

Question

Can someone explain me what it's wrong with that part of code?

$count_query_v1 = 'COUNT user_id FROM  stiri WHERE user_id = '.$_SESSION["user"]["nume"].''; 
$answer = mysql_query($count_query_v1) or die(mysql_error()); 
echo $answer;

Return me that error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'COUNT user_id FROM stiri WHERE user_id = John' at line 1

Do you mean `SELECT count (user_id)....`? – andrewsi Aug 29 '13 at 19:33 — andrewsi, Aug 29 '13 at 19:33

score 4 · Accepted Answer · edited May 23 '17 at 10:32

4

You need to add a select, and some parenthesis. This should work:

SELECT count(user_id) FROM stiri WHERE user_id = '.$_SESSION["user"]["nume"]

Read the documentation about COUNT. Also, your script is vulnerable to SQL Injection. I recommend you to also read this answer on how to prevent it.

edited May 23 '17 at 10:32

Community

1
1

answered Aug 29 '13 at 19:33

alxgb

543
8
18

2

Please also suggest fixing the SQL vulnerability – Explosion Pills Aug 29 '13 at 19:33
2

@ExplosionPills, done, and linked to the documentation. – alxgb Aug 29 '13 at 19:35
2

If you are going to add any other items to the select, don't forget to name the count as a variable so it's more easily accessible to PHP – Kris.Mitchell Aug 29 '13 at 19:36

Count something FROM database

1 Answers1