order by id not working with me

Question

I have made " news & updates " simple script

my query is:

$query = mysql_query("SELECT * FROM a_commants WHERE postid='$postid' ORDER BY id DESC LIMIT 0,10");

it shows last comment

i want to make it show all comments or at least 10 comments

if i change it to:

$query = mysql_query("SELECT * FROM a_commants WHERE postid='$postid'");

it shows first comment only

idk whats wrong :(

make sure you have more than one record for `$postid` value. — Devang Rathod, Sep 06 '13 at 11:07
i have three records for postid http://img585.imageshack.us/img585/4245/ulht.png — Ism3lawy, Sep 06 '13 at 11:11
probably you have one comment for given post so far ? Add more comments for that post and try again. OR show the code where you are displaying the records. Probably you need to use for-each/while loop etc.. — sakhunzai, Sep 06 '13 at 11:11

score 2 · Accepted Answer · edited May 23 '17 at 12:16

I think that the problem is in your php code, not MySQL. The query seems fine, as long as you have more than one comment, but it seems that you are not iterating through results, just printing the first row you get from db.

This should show last 10 comments:

$res = mysql_query("SELECT * FROM a_commants WHERE postid='$postid' ORDER BY id DESC LIMIT 0,10");
while($row = mysql_fetch_array($res)){ // iterate through results
    print_r($row); // print the row
}

And you should definitely switch to mysqli or PDO, and sanitize your inputs. The mysql_* functions are deprecated and going to be removed from PHP.

Did you get more than one row? – Zagor23 Sep 06 '13 at 11:21 — Zagor23, Sep 06 '13 at 11:21

order by id not working with me

1 Answers1