PHP/MySQL Error 1054 for form registration

Question

I have a registration form on my website and I am getting Error 1054 when a person tries to register.

The PHP code is:

$con=mysql_connect("server","database","password");
// Check connection
if (!$con)
{
    echo "Failed to connect to MySQL" . mysql_errno();
}

$sql="INSERT INTO database.table (User_ID, Name, Email, Telephone, MyPassword)
VALUES
(NULL,'$_POST[name]','$_POST[email]','$_POST[telephone]','$_POST[mypassword]')";

if (!mysql_query($sql,$con))
{
    die('Error: you fail'.mysql_errno());
}
$User_Id= mysql_insert_id();

$sql="INSERT INTO database.table (Address1, Address2, Address3, Address4)
VALUES
('$_POST[address1]','$_POST[address2]','$_POST[address3]','$_POST[address4]')";
//Inserts address into Address table


if (!mysql_query($sql,$con))
{
    die('Error: you failed' . mysql_errno());
}
echo "Thank you for registering with Market Buddy";

mysql_close($con);

I put the code into an online compiler to get a more detailed error description and for this line:

('$_POST[address1]','$_POST[address2]','$_POST[address3]','$_POST[address4]')";

It gives me the following error:

Syntax error, unexpected t_encapsed and whitespace, expecting T_String or T_Variable or T_num_string.

You need to escape your user input. See [here](http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php) — juergen d, Sep 10 '13 at 11:25

score 0 · Accepted Answer · answered Sep 10 '13 at 11:36

0

Strictly First: Use mysqli_* instead of mysql_*, your query have sql injection threat possiblity, use prepared statement query...

Error 1054: this type of error mostly occur when the column name is not vaild, check your table as in my sense.

answered Sep 10 '13 at 11:36

Dinesh

447
1
6
22

1

Or use PDO, but not mysql_* – Arjan Sep 10 '13 at 11:37

Honza · Answer 2 · 2013-09-10T11:47:39.230

-1

You must use braces {}, when access to the array:

$sql="INSERT INTO database.table (Address1, Address2, Address3, Address4)
VALUES
('{$_POST["address1"]}','{$_POST["address2"]}','{$_POST["address3"]}','{$_POST["address4"]}')";

Edit: Error 1054 means bad column - are you sure, that mentioned columns exists in your table? http://dev.mysql.com/doc/refman/5.0/es/error-handling.html#error_er_bad_field_error

edited Sep 10 '13 at 11:47

answered Sep 10 '13 at 11:26

Honza

974
10
18

Yes it was the wrong column names in the code. Can't believe I made that error. Think I need to step away from the computer and have a coffee. – user2753810 Sep 10 '13 at 11:56
Ok now the script posts to the second table only and not the first – user2753810 Sep 10 '13 at 12:03
Did you try add the same braces {} into both SQLs? Or what is current error message? – Honza Sep 14 '13 at 16:24

PHP/MySQL Error 1054 for form registration

2 Answers2