Undefined index: command

Question

These are my codes And i'm getting error

Notice: Undefined index: command in E:\xampp\htdocs\Shop_cart\products.php on line 17

Javascript:

<script language="javascript">
function addtocart(pid){
document.form1.productid.value=pid;
document.form1.command.value='add';
document.form1.submit();
}
</script>

HTML Code:

<form name="form1" action="">
<input type="hidden" name="productid" />
<input type="hidden" name="command" />
<input type="button" value="Add to Cart" onclick="addtocart(1)" />
</form>

PHP Code:

if($_REQUEST['command']=='add' && $_REQUEST['productid']>0){
$pid=$_REQUEST['productid'];
addtocart($pid,1);
header("location:shoppingcart.php");
exit();

There are 3.000+ questions like this. Use the search! – Sverri M. Olsen Sep 11 '13 at 08:20 — Sverri M. Olsen, Sep 11 '13 at 08:20

score 3 · Accepted Answer · answered Sep 11 '13 at 08:16

3

In your PHP code add isset check to the condition:

if ( isset($_REQUEST['command']) && $_REQUEST['command'] == 'add' && $_REQUEST['productid']>0 ) {}

answered Sep 11 '13 at 08:16

hsz

148,279
62
259
315

score 0 · Answer 2 · answered Sep 11 '13 at 08:19

0

Change

 if($_REQUEST['command']=='add' && $_REQUEST['productid']>0){

to

if(isset($_REQUEST['command']) && $_REQUEST['command']=='add' && $_REQUEST['productid']>0){

answered Sep 11 '13 at 08:19

rakeshjain

1,791
11
11

is your answer the same below? .. – Drixson Oseña Sep 11 '13 at 08:22
@DrixsonOseña yes it is......probably that answer got submitted while I was typing mine – rakeshjain Sep 11 '13 at 08:24

score 0 · Answer 3 · answered Sep 11 '13 at 08:28

Same to other answer but I would literally proceed something like this for security purposes and better layout of my code.

//Check if request has been made
if (isset($_REQUEST['command'])){

  //proceed for checking
  if($_REQUEST['command'] == 'add' && $_REQUEST['productid']>0 )
  {
    //Your code here
  }

}else{
   //redirect or whatsoever
}

Undefined index: command

3 Answers3