Mysql_query() expects parameter 1 to be string

Question

I am pulling my hair out here. I have an html form for data entry and posting to insert_ac.php and I get this error:

Warning: mysql_query() expects parameter 1 to be string, resource given in /home/content/52/11733052/html/admin/insert_ac.php on line 24

Here is the code from insert_ac.php:

<?php

     $username = "nlladmin";
     $password = "password";
     $hostname = "localhost"; 

     $link = mysql_connect($hostname, $username, $password) 
             or die("Unable to connect to MySQL");

     $selected = mysql_select_db("nlladmin",$link) 
             or die("Could not select Admin Database");

    // Get values from form 
     $make=$_POST['make'];
     $model=$_POST['model'];

    // Insert data into mysql 
      $sql="INSERT INTO assets (make, model)VALUES('$make', '$model')";
       if (!mysql_query($link,$sql))
     {
          die('Error: ' . mysql_error($link));
     }

    echo "1 record added";

    mysql_close();
    ?>

Any suggestion will be helpful.

In this case: RTFM. Then RTFEM (read the fine error message) again. Please. Really. — deceze, Sep 12 '13 at 08:54
A: you should not be using the mysql_ functions, they are depreciated (for a very good reason). B: you have a SQL injection hole, see: http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php?lq=1, If you must insist on using the mysl_ lib, learn the use `mysql_real_escape_string`. — Johan, Sep 12 '13 at 09:08

score 1 · Answer 1 · answered Sep 12 '13 at 09:03

1

Besides that you should not be using mysql_ functions,

you swapped the parameters in

resource mysql_query ( string $query [, resource $link_identifier = NULL ] )

That's what the error msg says.

if (!mysql_query($sql, $link))
....

works.

answered Sep 12 '13 at 09:03

Daniel W.

31,164
13
93
151

score 0 · Answer 2 · answered Sep 12 '13 at 09:04

0

The first parameter is the query, the second the resource.

mysql_query($sql, $link);

answered Sep 12 '13 at 09:04

davey

1,801
2
17
22

score -1 · Answer 3 · answered Sep 12 '13 at 09:00

-1

the function mysql_query() just takes the query as a parameter , like the following :

mysql_query($sql);

answered Sep 12 '13 at 09:00

Leo Bali

309
1
8

it takes also 2 parameters, correct answer would be `ysql_query($sql, $link);` – Daniel W. Sep 12 '13 at 09:01
Imagine having several database connections. You should, if usign `mysql_` functions, always include the resource identifier. – Daniel W. Sep 12 '13 at 09:02
so i think he sent the parameters in the wrong order :) – Leo Bali Sep 12 '13 at 09:02

Mysql_query() expects parameter 1 to be string

3 Answers3

Related