0

I am trying to extract links from webpages, but it seems webbrowser does not navigate, so I get infinite loop at webbrowser1.readstate <> readystate_complete...

HOWEVER, if make a breakpoint at webbrowser1.readstate <> readystate_complete, the webbrowser navigates successfully in the userform, and code works....

Any ideas? Thanks

Do Until n = num

    WebBrowser1.Navigate URL

    Do While WebBrowser1.readyState <> READYSTATE_COMPLETE

    Loop


    If WebBrowser1.readyState = READYSTATE_COMPLETE Then
        'code
    end if

    n = n +1

loop
Ben Rhys-Lewis
  • 3,118
  • 8
  • 34
  • 45
user2468695
  • 49
  • 2
  • 8
  • found a solution, don't use webbrowser, use the internet explorer application, see http://www.jpsoftwaretech.com/excel-vba/automate-internet-explorer/ – user2468695 Sep 26 '13 at 01:27

1 Answers1

3

The while loop you use in your question and in your answer is a busy waiting tight loop, consuming CPU cycles in vain while waiting for something to happen. It works (sort of) for InternetExplorer object, because the latter runs in its own separate process. It doesn't work for in-process WebBrowser control, because your loop doesn't pump Windows messages, which is required for navigation to work. If you want to stick with the loop approach, consider placing Sleep 250 and DoEvents calls inside your loop to mitigate busy waiting and pump messages. This is still not recommended, instead you should consider re-factoring your code to use WebBrowser_DocumentComplete event.

Community
  • 1
  • 1
noseratio
  • 59,932
  • 34
  • 208
  • 486
  • 1
    Thanks. The DocumentComplete method seemed to be the standard, but I needed a way to keep all my code in one subroutine, since it loops to before the IE/webbrowser is called and uses stored data from before calling. – user2468695 Sep 26 '13 at 10:20