Initialise CDI injected components in constructor or post-method?

Question

I'm using CDI in Vaadin context, but that should not matter for my question: Is it in general better to inject objects inside the constructor, or directly as a member variable? Especially if these objects have to be further configured for the component to work.

The following shows two different CDI possibilities:

@UIScoped
public class MyMenuBar extends CustomComponent {
    @Inject @New private Label label;
    @Inject @New private MenuBar menuBar;

    @PostConstruct
    private void init() {
        //set label text, define menu entries
        setCompositionRoot(menuBar);
    }
}

@UIScoped
public class MyMenuBar extends CustomComponent {
    private Label label;
    private MenuBar menuBar;

    @Inject
    public MyMenuBar(@New Label label, @New MenuBar menuBar) {
        //set label text, define menu entries
        setCompositionRoot(menuBar);
    }
}

Is there a best practice? Why should one prefer the one option over the other? Or is it just a matter of personal choice?

score 6 · Answer 1 · edited May 23 '17 at 12:08

6

The constructor is ONLY for object construction stuff; i.e. NEVER CALL BUSINESS LOGIC FROM THE CONSTRUCTOR. Allways use @PostConstruct for business initialization logic. See my answer to this for a more detailed explanation.

In short the constructor may be called by the system in "unexpected" ways.

Additionally, in @PostConstruct you are guaranteed to have all dependencies (event fields) injected.

edited May 23 '17 at 12:08

Community

1
1

answered Sep 26 '13 at 10:25

Nikos Paraskevopoulos

39,514
12
85
90

So to say: if I @Inject all objects and stuff that are to be used in this class, I probably never need a constructor? – membersound Sep 26 '13 at 10:54
I'm not sure what you mean; what I say is that *if* you have any `@Inject`ed fields, these will have been injected in the `@PostConstruct` method. The only dependencies that are available in the constructor are constructor `@Inject`ed arguments. – Nikos Paraskevopoulos Sep 26 '13 at 13:13

Petr Mensik · Accepted Answer · 2013-09-26T12:37:28.357

Always use @PostConstruct when you work with injected resources(CDI and EJB beans for instance) because only then you can be sure that they really have been already injected into the bean (this is provided by the container). So that's the reason why you shouldn't rely on constructor when it comes to injected resources (they might get injected but you can't be sure).

However, constructor initialization can still be useful if you deal with non-injected resources, so you can call some methods or init variables, it's more matter of taste in this case. But you can never make mistake by using @PostConstruct all the time.

Initialise CDI injected components in constructor or post-method?

2 Answers2