HashMap overridden by last value

Question

Statement selectStatement = connection.createStatement();
        ResultSet selectResultSet = selectStatement.executeQuery(query);
        logger.info("sql query " + selectStatement.toString());
        ResultSetMetaData rsmd = selectResultSet.getMetaData();
        int columnsNumber = rsmd.getColumnCount();
        String[] row = new String[columnsNumber];

        int ctr = 0;
        logger.info("Reading from database...");
        while(selectResultSet.next())
        {
            for(int i=0;i<columnsNumber;i++){
                row[i] = selectResultSet.getString(i+1);
            }
            System.out.println();
            dataFromQuery.put(ctr++, row);
        }
        selectResultSet.close();

On reading back from HashMap, it prints only the last row 'n' number of times.

Subhrajyoti Majumder · Accepted Answer · 2013-09-27T10:02:40.913

3

What you are missing is - row = new String[columnsNumber]; in while loop, which actually cause over writing array object value and you are adding same object to HashMap.

...
while(selectResultSet.next()){
     row = new String[columnsNumber];
     for(int i=0;i<columnsNumber;i++){
         row[i] = selectResultSet.getString(i+1);
     }
     System.out.println();
     dataFromQuery.put(ctr++, row);
}
...

edited Sep 27 '13 at 10:02

answered Sep 27 '13 at 09:54

Subhrajyoti Majumder

40,646
13
77
103

score 1 · Answer 2 · answered Sep 27 '13 at 09:55

1

Declare row array inside the while loop, so that each row gets its own copy, currently each row in map references the same row array which is overwritten by the last loop.

answered Sep 27 '13 at 09:55

Abdullah Shaikh

2,567
6
30
43

HashMap overridden by last value

2 Answers2

Linked