C++ separate function print

Question

I'm trying to write a test function for print. Everything compiles fine but why does it not print? what am i doing wrong? can someone please help me out? thanks

oneLine.cpp

#include "oneLine.h"
#include <iostream>


OneLine::OneLine() {

cout << "test";

}

OneLine::~OneLine() {

cout << "~test";

}

oneLine.h

#include <string>
using namespace std;

class OneLine {

    OneLine();
    ~OneLine();
    void breakLine();
    void printReverse();
    istream &readLine(istream& is);
    string returnLine();

private:
    string oneLine;
    char **words;
    int wordCount;
    void resetLine();

};

main.cpp

#include "oneLine.h"

using namespace std;

int main () {

OneLine oLine();


return 0;
}

Look up "[most] vexing parse." – Angew is no longer proud of SO Sep 30 '13 at 19:11 — Angew is no longer proud of SO, Sep 30 '13 at 19:11

score 5 · Accepted Answer · edited May 23 '17 at 12:21

5

This is a function declaration:

OneLine oLine(); // declaration of a function returning a OneLine object

To default construct a OneLine object, you need

OneLine oLine;

or, in C++11, you can also use {}:

OneLine oLine{};

Next, as @POW points out in the comments, your default constructor and destructor have to be made public. Currently they are private.

As an aside, note that using namespace std is considered bad practice, especially in header files.

edited May 23 '17 at 12:21

Community

1
1

answered Sep 30 '13 at 19:08

juanchopanza

223,364
34
402
480

1

and constructor & destructor needs to be in `public` section, for this case – P0W Sep 30 '13 at 19:13
1

@P0W Good catch! I added it to my answer. – juanchopanza Sep 30 '13 at 19:16
i change "OneLine oLine();" to "OneLine oLine;" in the main.cpp but it doesnt even compile. what do you mean? – NewFile Sep 30 '13 at 19:17
1

@NewFile it could be because your constructor and destructor are `private`. – juanchopanza Sep 30 '13 at 19:18
only the variable names in oneLine.h are private the functions are natually set to public right? – NewFile Sep 30 '13 at 19:19
2

@NewFile As it stands, *everything* is `private` in `OneLine`. – juanchopanza Sep 30 '13 at 19:20
how do i work with that? sorry im really confused now – NewFile Sep 30 '13 at 19:39
1

@NewFile just put `public:` before the constructor. Everything until the `private:` will be public. – juanchopanza Sep 30 '13 at 19:40

C++ separate function print

1 Answers1