how to update Ui from background task

Question

My app is not working on android version 4.1 gives exception like android.os.NetworkOnMainThreadException

i have search on stackoverflow advice me to do network thread in background AsyncTask so before use backgroundtask, My screen look like this https://i.stack.imgur.com/PZxPR.jpg show multiple rows in nutrition's and ingredient tags after using backgroundtask my screen look like this https://i.stack.imgur.com/91qhg.jpg show only single row in ingredients and nutrition tags

before background task code is this see below

public class fifthscreen extends Activity {
String num = null;
TextView ingredient;

long Menu_ID;
String dish_name;

String status;

HorizontalListView listview;
CategoryListAdapter3 cla;
String DescriptionAPI;

TextView txt1, txt2, txt3;
ImageView img1;
String URL, URL2;
String SelectMenuAPI;

static ArrayList<Long> Category_ID = new ArrayList<Long>();
static ArrayList<String> Category_name = new ArrayList<String>();
static ArrayList<String> Category_image = new ArrayList<String>();

public static String allergen2;
private AQuery androidAQuery;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.fifthscreen);
    ingredient = (TextView) findViewById(R.id.ingredient);
    img1 = (ImageView) findViewById(R.id.test_button_image);

    txt1 = (TextView) findViewById(R.id.menuname);
    txt3 = (TextView) findViewById(R.id.description);

    Intent iGet = getIntent();

    ImageView options = (ImageView) findViewById(R.id.options5);
    androidAQuery = new AQuery(this);

    options.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {
            Intent iMenuList = new Intent(fifthscreen.this,
                    LinkButtons.class);
            startActivity(iMenuList);
        }
    });

    dish_name = iGet.getStringExtra("dish_name");

    listview = (HorizontalListView) this.findViewById(R.id.listview2);

    cla = new CategoryListAdapter3(fifthscreen.this);
    listview.setAdapter(cla);

    parseJSONData();

}

void clearData() {
    Category_ID.clear();
    Category_name.clear();
    Category_image.clear();

}

public void parseJSONData() {

    SelectMenuAPI = Utils.dishdescription + dish_name;

    clearData();
    URL = SelectMenuAPI;
    URL2 = URL.replace(" ", "%20");

    try {

        HttpClient client = new DefaultHttpClient();
        HttpConnectionParams
                .setConnectionTimeout(client.getParams(), 15000);
        HttpConnectionParams.setSoTimeout(client.getParams(), 15000);
        HttpUriRequest request = new HttpGet(URL2);
        HttpResponse response = client.execute(request);
        InputStream atomInputStream = response.getEntity().getContent();
        BufferedReader in = new BufferedReader(new InputStreamReader(
                atomInputStream));

        String line;
        String str = "";
        while ((line = in.readLine()) != null) {
            str += line;
        }

        JSONObject json2 = new JSONObject(str);

        status = json2.getString("status");
        if (status.equals("1")) {

            JSONArray school2 = json2.getJSONArray("data");

            for (int i = 0; i < school2.length(); i++) {

                String name = school2.getJSONObject(0).getString("name");
                txt1.setText(name);

                String description = school2.getJSONObject(0).getString(
                        "description");

                txt3.setText(description);

                String url1 = school2.getJSONObject(0).getString("image");

                androidAQuery.id(img1).image(url1, false, false);

            }

            JSONObject school3 = json2.getJSONObject("dish_nutrition");

            final TableLayout table = (TableLayout) findViewById(R.id.table2);

            for (int j = 0; j < school3.length(); j++) {

                String s = String.valueOf(j + 1);

                final View row = createRow(school3.getJSONObject(s));
                table.addView(row);

            }

            JSONArray school4 = json2.getJSONArray("dish_allergen");
            //
            for (int i = 0; i < school4.length(); i++) {
                JSONObject object = school4.getJSONObject(i);

                Category_ID.add((long) i);
                Category_name.add(object.getString("name"));
                Category_image.add(object.getString("image"));
                listview.setAdapter(cla);

            }

    final LinearLayout table3 = (LinearLayout) findViewById(R.id.table3);

            JSONArray school5 = json2.getJSONArray("dish_ingredient");

            for (int i = 0; i < school5.length(); i++) {

                final View row2 = createRow2(school5.getJSONObject(i));
                table3.addView(row2);

            }

        }

        else {

            JSONArray school2 = json2.getJSONArray("data");
            for (int i = 0; i < school2.length(); i++) {
                JSONObject object = school2.getJSONObject(i);

                Category_ID.add((long) i);
                Category_name.add(object.getString("name"));

            }

        }

    } catch (MalformedURLException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    } catch (IOException e) {
        // TODO Auto-generated catch block
        // IOConnect = 1;
        e.printStackTrace();
    } catch (JSONException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
}

public View createRow(JSONObject item) throws JSONException {
    View row = getLayoutInflater().inflate(R.layout.rows, null);
    ((TextView) row.findViewById(R.id.localTime)).setText(item
            .getString("qty"));
    ((TextView) row.findViewById(R.id.apprentTemp)).setText(item
            .getString("name"));

    return row;
}

public View createRow2(JSONObject item) throws JSONException {

    View row2 = getLayoutInflater().inflate(R.layout.row2, null);
    ((TextView) row2.findViewById(R.id.name)).setText(item
            .getString("name"));
    ((TextView) row2.findViewById(R.id.subingredients)).setText(item
            .getString("sub_ingredients"));

    return row2;
}

    }

After using AsyncTask see this code below

 public class fifthscreen extends Activity {
String num = null;
TextView ingredient;

long Menu_ID;
String dish_name;

String status;

HorizontalListView listview;
CategoryListAdapter3 cla;
String DescriptionAPI;

TextView txt1, txt2, txt3;
ImageView img1;
String URL, URL2;
String SelectMenuAPI;
String description;

int IOConnect = 0;
String name;
String url1;
TableLayout table;
LinearLayout table3;
View row;
View row2;

static ArrayList<Long> Category_ID = new ArrayList<Long>();
static ArrayList<String> Category_name = new ArrayList<String>();
static ArrayList<String> Category_image = new ArrayList<String>();
public static String allergen2;
private AQuery androidAQuery;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.fifthscreen);
    if (android.os.Build.VERSION.SDK_INT > 9) {
        StrictMode.ThreadPolicy policy = new StrictMode.ThreadPolicy.Builder()
                .permitAll().build();
        StrictMode.setThreadPolicy(policy);
    }
    ingredient = (TextView) findViewById(R.id.ingredient);
    img1 = (ImageView) findViewById(R.id.test_button_image);

    txt1 = (TextView) findViewById(R.id.menuname);
    // txt2 = (TextView) findViewById(R.id.test_button_text1);
    txt3 = (TextView) findViewById(R.id.description);

    table = (TableLayout) findViewById(R.id.table2);
    table3 = (LinearLayout) findViewById(R.id.table3);

    Intent iGet = getIntent();

    ImageView options = (ImageView) findViewById(R.id.options5);
    androidAQuery = new AQuery(this);

    options.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {
            Intent iMenuList = new Intent(fifthscreen.this,
                    LinkButtons.class);
            startActivity(iMenuList);
        }
    });

    dish_name = iGet.getStringExtra("dish_name");

    listview = (HorizontalListView) this.findViewById(R.id.listview2);

    cla = new CategoryListAdapter3(fifthscreen.this);

    new getDataTask().execute();

    // listview.setAdapter(cla);

    ImageView btnback = (ImageView) findViewById(R.id.btnback);

    btnback.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {
            finish();
        }
    });

    parseJSONData();

}

void clearData() {
    Category_ID.clear();
    Category_name.clear();
    Category_image.clear();

}

public class getDataTask extends AsyncTask<Void, Void, Void> {

    getDataTask() {

    }

    @Override
    protected void onPreExecute() {
        // TODO Auto-generated method stub

    }

    @Override
    protected Void doInBackground(Void... arg0) {
        // TODO Auto-generated method stub
        parseJSONData();
        return null;
    }

    @Override
    protected void onPostExecute(Void result) {
        // TODO Auto-generated method stub
        txt1.setText(name);
         txt3.setText(description);
        androidAQuery.id(img1).image(url1, false, false);

        table.addView(row);
        table3.addView(row2);
        listview.setAdapter(cla);

    }
}

public void parseJSONData() {

    SelectMenuAPI = Utils.dishdescription + dish_name;

    clearData();
    URL = SelectMenuAPI;
    URL2 = URL.replace(" ", "%20");

    try {

        HttpClient client = new DefaultHttpClient();
        HttpConnectionParams
                .setConnectionTimeout(client.getParams(), 15000);
        HttpConnectionParams.setSoTimeout(client.getParams(), 15000);
        HttpUriRequest request = new HttpGet(URL2);
        HttpResponse response = client.execute(request);
        InputStream atomInputStream = response.getEntity().getContent();
        BufferedReader in = new BufferedReader(new InputStreamReader(
                atomInputStream));

        String line;
        String str = "";
        while ((line = in.readLine()) != null) {
            str += line;
        }

        JSONObject json2 = new JSONObject(str);

        status = json2.getString("status");
        if (status.equals("1")) {

            JSONArray school2 = json2.getJSONArray("data");

            for (int i = 0; i < school2.length(); i++) {

                name = school2.getJSONObject(0).getString("name");

                description = school2.getJSONObject(0).getString(
                        "description");

                url1 = school2.getJSONObject(0).getString("image");

            }

            JSONObject school3 = json2.getJSONObject("dish_nutrition");

            for (int j = 0; j < school3.length(); j++) {

                String s = String.valueOf(j + 1);

                row = createRow(school3.getJSONObject(s));

            }

            JSONArray school4 = json2.getJSONArray("dish_allergen");
            //
            for (int i = 0; i < school4.length(); i++) {
                JSONObject object = school4.getJSONObject(i);

                Category_ID.add((long) i);
                Category_name.add(object.getString("name"));
                Category_image.add(object.getString("image"));

            }

            JSONArray school5 = json2.getJSONArray("dish_ingredient");

            for (int i = 0; i < school5.length(); i++) {

                row2 = createRow2(school5.getJSONObject(i));

            }

        }

        else {

            JSONArray school2 = json2.getJSONArray("data");
            for (int i = 0; i < school2.length(); i++) {
                JSONObject object = school2.getJSONObject(i);

                Category_ID.add((long) i);
                Category_name.add(object.getString("name"));

            }

        }

    } catch (MalformedURLException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    } catch (IOException e) {
        // TODO Auto-generated catch block
        // IOConnect = 1;
        e.printStackTrace();
    } catch (JSONException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
}

public View createRow(JSONObject item) throws JSONException {
    View row = getLayoutInflater().inflate(R.layout.rows, null);
    ((TextView) row.findViewById(R.id.localTime)).setText(item
            .getString("qty"));
    ((TextView) row.findViewById(R.id.apprentTemp)).setText(item
            .getString("name"));

    return row;
}

public View createRow2(JSONObject item) throws JSONException {

    View row2 = getLayoutInflater().inflate(R.layout.row2, null);
    ((TextView) row2.findViewById(R.id.name)).setText(item
            .getString("name"));
    ((TextView) row2.findViewById(R.id.subingredients)).setText(item
            .getString("sub_ingredients"));

    return row2;
}

 }

Please Help

Thanks in Advance...:)

i think this lines not update in postExecute row2 = createRow2(school5.getJSONObject(i)); — smart guy, Oct 02 '13 at 06:29
why you are calling parsejsondata twice? in asynctask as well as in oncreate — Siddhesh, Oct 02 '13 at 06:41
in oncreate i forget to remove just tell me only how to show this loop values row = createRow(school3.getJSONObject(s)); in postexecute — smart guy, Oct 02 '13 at 06:50
**Are you really smart guy?** :) check: [android.os.NetworkOnMainThreadException](http://stackoverflow.com/search?q=android.os.NetworkOnMainThreadException) — Paresh Mayani, Oct 02 '13 at 07:01
paresh just only tell me im updating my ui in forloop before using asyntask at this line final View row = createRow(school3.getJSONObject(s)); how to update Ui same like this from postexecute — smart guy, Oct 02 '13 at 07:03
You should use volley for JSON !! And maybe UniversalImageLoader for image — An-droid, Oct 02 '13 at 07:47

JWqvist · Answer 1 · 2013-10-02T06:59:34.677

2

Use the Handler object from your MainActivity and post a runnable. To use it from the backgrund you need to make the object a static that you can call outside of your MainActivity or you can create a static instance of the Activity to access it.

Inside the Activity

    private static Handler handler;


    handler = new Handler();

    handler().post(new Runnable() {

        public void run() {
            //ui stuff here :)
        }
    });

    public static Handler getHandler() {
       return handler;
    }

Outside the Activity

    MainActivity.getHandler().post(new Runnable() {

            public void run() {
                //ui stuff here :)
            }
        });

edited Oct 02 '13 at 06:59

answered Oct 02 '13 at 06:35

JWqvist

717
6
15

Create the handler as a static in you MainActivity then create static getter so you can call the method from the background – JWqvist Oct 02 '13 at 06:39
Use this method where you manipulate with UI stuff like set text. – JWqvist Oct 02 '13 at 06:57

score 1 · Accepted Answer · answered Oct 02 '13 at 06:45

1

You can use **runOnUiThread()** like this:

try {
   // code runs in a thread
   runOnUiThread(new Runnable() {
       @Override
       public void run() {

         // YOUR CODE

       }
  });
} catch (final Exception ex) {
     Log.i("---","Exception in thread");
}

answered Oct 02 '13 at 06:45

Pratik Butani

60,504
58
273
437

how to Update UI using forloop inside postexecute – smart guy Oct 02 '13 at 07:09

score 0 · Answer 3 · answered Oct 02 '13 at 06:41

0

You need to create AsyncTask class and use it Read here more: AsyncTask

Example would look like this:

private class UploadTask extends AsyncTask<Void, Void, Void>
{
    private String in;

    public UploadTask(String input)
    {
        this.in = input;
    }

    @Override
    protected void onPreExecute()
    {
        //start showing progress here
    }

    @Override
    protected Void doInBackground(Void... params)
    {
      //do your work
        return null;
    }

    @Override
    protected void onPostExecute(Void result)
    {
        //stop showing progress here
    }

}

And start task like this:

UploadTask ut= new UploadTask(input); ut.execute();

answered Oct 02 '13 at 06:41

andDev

66
1
3

but see my code im using forloop inside parsemethod and add row2 = createRow2(school5.getJSONObject(i)); this line not work on postexecute method and just show only single row – smart guy Oct 02 '13 at 06:47
i already did like this add row2 = createRow2(school5.getJSONObject(i)); and inside postexecute show like this table3.addView(row2); – smart guy Oct 02 '13 at 06:49
how to show this loop value row = createRow(school3.getJSONObject(s)); from parseJSONData(); show in postexecute – smart guy Oct 02 '13 at 06:51

score 0 · Answer 4 · answered Oct 02 '13 at 08:41

you are handling ui in these methods

public View createRow(JSONObject item) throws JSONException {
    View row = getLayoutInflater().inflate(R.layout.rows, null);
    ((TextView) row.findViewById(R.id.localTime)).setText(item
            .getString("qty"));
    ((TextView) row.findViewById(R.id.apprentTemp)).setText(item
            .getString("name"));

    return row;
}

public View createRow2(JSONObject item) throws JSONException {

    View row2 = getLayoutInflater().inflate(R.layout.row2, null);
    ((TextView) row2.findViewById(R.id.name)).setText(item
            .getString("name"));
    ((TextView) row2.findViewById(R.id.subingredients)).setText(item
            .getString("sub_ingredients"));

    return row2;
}

which are called in background thread

if possible do it in onPostExecute or you can use runOnUiThread and Handler.

how to update Ui from background task

4 Answers4

Linked