Android programmatic relative layout: BELOW rule not working?

Question

I want to create a layout (see class RosterPlayerView below) that comprises an image with text below it and then instantiate that view multiple times in a relative layout. I used relative layout instead of linear as the layout will become more complex.

When I first ran the code below (but without the setId calls) the text appeared above the image. Thanks to this stack overflow article I discovered that relative layout needs unique widget ids to work. But when I added the setId() calls the text view is not displayed at all.

What am I doing wrong?

public class RosterPlayerView extends RelativeLayout {

    ImageView imageView;
    TextView textView;
    static int layoutId = 100;

    public RosterPlayerView(Context context, int playerId, Drawable photo) {
        super(context);
        imageView = new ImageView(context);
        textView = new TextView(context);
        addView(imageView, new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));
        imageView.setId(layoutId++);
        RelativeLayout.LayoutParams timeLayoutParams = new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);
        timeLayoutParams.addRule(RelativeLayout.BELOW, imageView.getId());
        addView(textView, timeLayoutParams);        
        imageView.setImageDrawable(photo);
        textView.setId(layoutId++);
        textView.setText("0:00");
    }
}

JWqvist · Answer 1 · 2013-10-06T08:34:16.333

0

Try to set the Id of you imageView before adding it to the layout.

You can also create a LinearLayout with the imageView and textView inside before adding it to the RelativeLayout

edited Oct 06 '13 at 08:34

answered Oct 04 '13 at 06:29

JWqvist

717
6
15

Jeppe, thanks for the help. Sadly textView still not appearing. – whenrybruce Oct 04 '13 at 16:29

score 0 · Answer 2 · answered Oct 04 '13 at 06:44

0

a LinearLayout would be an awful lot simpler for what you are trying to do. So would inflating an XML layout, for that matter.

answered Oct 04 '13 at 06:44

Philip Sheard

5,789
5
27
42

Philip - you're right linear layout is much simpler. I went with relative layout as I'd like to influence position of textView and add more widgets to layout. Thanks for your help. – whenrybruce Oct 04 '13 at 16:32

Android programmatic relative layout: BELOW rule not working?

2 Answers2