How to set an onClickListener on an included layout?

Question

I have a layout with an ImageButton that I included in several other layouts.

ImageButton Layout:

call_cancelled.xml

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent" >

<LinearLayout
    android:id="@+id/callEndLayout"
    android:layout_width="70dp"
    android:layout_height="70dp"
    android:height="70dip"
    android:orientation="horizontal"
    android:paddingBottom="5dp"
    android:paddingTop="5dp" >

    <ImageButton
        android:id="@+id/phoneEnd"
        android:layout_width="63dp"
        android:layout_height="63dp"
        android:paddingBottom="7dp"
        android:background="@drawable/phone_cancelled"  />

</LinearLayout>

My include:

  <include
   android:id="@+id/includeCallEnd0"
   android:layout_width="70dp"
   android:layout_height="70dp"
   android:layout_alignBottom="@+id/include"
   android:layout_alignParentRight="true"
   layout="@layout/call_cancelled" />

For this includes I need a onClickListener when it's pressed. I tried this:

View endcall0 = (View) findViewById(R.id.includeCallEnd0);

 endcall0.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View arg0) {

            Intent callIntent = new Intent(Intent.ACTION_CALL_BUTTON);
            startActivity(callIntent);

            int id = viewFlipper.getDisplayedChild();

            if (id == 0) {
                hideSoftKeyboard();
            }
        }
     });

But it doesn't work. Does anybody know the solution?

`It doesn't work` means that code is not compiling or app is crashing at runtime? — gunar, Oct 07 '13 at 13:34
Replace `findViewById(R.id.includeCallEnd0)` with `findViewById(R.id.includeCallEnd0).findViewById(R.id.phoneEnd)` and it should work — Sherif elKhatib, Oct 07 '13 at 13:35

Sherif elKhatib · Accepted Answer · 2013-10-07T13:47:50.243

8

Replace findViewById(R.id.includeCallEnd0) with findViewById(R.id.includeCallEnd0).findViewById(R.id.phoneEnd) and it should work

because you want to set the click listener on the ImageButton and not the whole layout

Use the following function to set the OnClickListener once:

private static void applyListener(View child, OnClickListener listener) {
    if (child == null)
        return;

    if (child instanceof ViewGroup) {
        applyListener((ViewGroup) child, listener);
    }
    else if (child != null) {
        if(child.getId() == R.id.phoneEnd) {
            child.setOnClickListener(listener);
        }
    }
}

private static void applyListener(ViewGroup parent, OnClickListener listener) {
    for (int i = 0; i < parent.getChildCount(); i++) {
        View child = parent.getChildAt(i);
        if (child instanceof ViewGroup) {
            applyListener((ViewGroup) child, listener);
        } else {
            applyListener(child, listener);
        }
    }
}

Use applyListener(rootView, yourOnClickListener);

edited Oct 07 '13 at 13:47

answered Oct 07 '13 at 13:35

Sherif elKhatib

45,786
16
89
106

It works. thanks. Now I have to write an onClickListener for every single include. Is there a way to reach all includes with 1 onclickListener? – silvia_aut Oct 07 '13 at 13:42
Sorry have a another question. whats the rootView? – silvia_aut Oct 08 '13 at 06:09
rootView in this case is any parent any parent view that contains all your ImageButtons in the view hierarchy. In general, it is the first view in your xml, usually a LinearLayout or RelativeLayout or FrameLayout that contains everything else inside. – Sherif elKhatib Oct 08 '13 at 07:12
This answer is pure genius! Thank you so much Sherif. – Squareoot Oct 01 '20 at 19:09
What if I do want to put the listener on the whole layout? – Hiro Nov 14 '20 at 14:17
@Hiro in that case add listener to top layout (LinearLayout in this case) – Mangaldeep Pannu Jul 08 '21 at 07:15

score 4 · Answer 2 · answered Feb 26 '15 at 14:30

4

You could have done

LinearLayout endcall0 = (LinearLayout) findViewById(R.id.includeCallEnd0);

and then simply

ImageButton imgBtn = (ImageButton) endcall0.findViewById(R.id. phoneEnd); 
imgBtn.setOnClickListener(this);

answered Feb 26 '15 at 14:30

An-droid

6,433
9
48
93

Only this solution worked for me – Ramakrishna Joshi Jul 19 '23 at 19:18

score 0 · Answer 3 · answered Oct 07 '13 at 13:33

0

Try to set your clickListener on callEndLayout (LinearLayaout)

answered Oct 07 '13 at 13:33

A.S.

4,574
3
26
43

score 0 · Answer 4 · answered May 11 '22 at 14:19

0

very easy with Kotlin::

{appBar} is include view

{btnOrders} is button view inside appBar layout

binding.appBar.btnOrders.setOnClickListener {
   startActivity(Intent(this, OrdersActivity::class.java))
}

answered May 11 '22 at 14:19

Abd Nezar

341
4
8

How to set an onClickListener on an included layout?

4 Answers4

Linked