trying to find if a string contains a string

Question

I am trying to find whether or not a string is contained within a string, but it is always true. Why is this always true

<?php

$test = 'ORDER BY `views`';
if(strpos($test,'views') !== true) echo 'true';
else echo 'false';

?>

score 3 · Accepted Answer · answered Oct 08 '13 at 12:43

3

You're using the parameters for strpos() incorrectly.

You're using strpos($needle, $haystack) but it should actually be strpos($haystack, $needle)

Note that strpos() returns FALSE if the needle was not found in the haystack. So, you'll need to check if it returns FALSE (instead of TRUE).

With your code, it becomes:

if(strpos($test, 'views') !== FALSE) 
    echo 'true';
else 
    echo 'false';

answered Oct 08 '13 at 12:43

Amal Murali

Sorry, that was an accident just from experimenting, but I am still getting the same issue. – Flashpacker Oct 08 '13 at 12:48
@Flashpacker: Did you check the demo? – Amal Murali Oct 08 '13 at 12:49
ok sure, I will play around with it, so I can never use true? Has to be false? – Flashpacker Oct 08 '13 at 12:58
@Flashpacker: Yeah, that's the recommended way to do it. Have a look at the official documentation for [`strpos()`](http://php.net/strpos). – Amal Murali Oct 08 '13 at 12:59

Shakti Patel · Answer 2 · 2013-10-08T13:22:37.370

-1

check this

 $test = 'ORDER BY `views`';
   if (strpos($test,'views') !== false) {
        echo 'true';
    } else {
        echo 'false';
    }

also use

You can use these string functions,

strstr — Find the first occurrence of a string

stristr — Case-insensitive strstr()

strrchr — Find the last occurrence of a character in a string

strpos — Find the position of the first occurrence of a substring in a string

strpbrk — Search a string for any of a set of characters

If that doesn't help then you should use preg regular expression

preg_match — Perform a regular expression match

edited Oct 08 '13 at 13:22

answered Oct 08 '13 at 13:08

Shakti Patel

1

How is this different from [this](http://stackoverflow.com/a/19248048/1438393) answer (except the curly braces)? – Amal Murali Oct 08 '13 at 13:10
1

@AmalMurali put this answer 30 minutes before :) Why do You duplicate answer? – Adam Oct 08 '13 at 13:11
@Adam AND AmalMurali check now – Shakti Patel Oct 08 '13 at 13:23

2 Answers2