Can't check string value

Question

I am trying to check a string value in if but it always is entering the else, what Is wrong here? Thank you

public void alertBtn(View v){
    EditText text = (EditText)findViewById(R.id.editText1);
    String value = text.getText().toString();
    String password="asd";
    if (value==password){

            new AlertDialog.Builder(this)
            .setTitle("Success")
            .setMessage("Correct Password")
            .setNeutralButton("OK", null)
            .show();
        }
    else
        new AlertDialog.Builder(this)
        .setTitle("Error")
        .setMessage("Wrong password")
        .setNeutralButton("OK", null)
        .show();



}

For those who answer, you might also want to give an explanation..... Specially when this question has been answered 1000 times. — Maroun, Oct 13 '13 at 08:53
What would you like me to explain? I am just trying to make a log in screen. — S.I.Tsaklidis, Oct 13 '13 at 08:59

score 2 · Answer 1 · answered Oct 13 '13 at 08:54

2

Using the == operator will compare the references to the strings not the string themselves.

String value = text.getText().toString();
String password="asd";

if (value.equals(password))
{
}

answered Oct 13 '13 at 08:54

Basbous

3,927
4
34
62

score 1 · Answer 2 · edited May 23 '17 at 11:52

1

Use .equals or .equalsIgnoreCase() to compare strings

What is the difference between == vs equals() in Java?

 if (value.equals(password)){

Also move the initialization of editText to onCreate. There is no need to initialize edittext everytime on button click

  text = (EditText)findViewById(R.id.editText1); // in onCreate

and declare EditText text as class member

edited May 23 '17 at 11:52

Community

1
1

answered Oct 13 '13 at 08:51

Raghunandan

132,755
26
225
256

Thank you a lot, is there any site where I can find basic commands? – S.I.Tsaklidis Oct 13 '13 at 08:56

score 1 · Answer 3 · answered Oct 13 '13 at 08:52

1

use equals() function

Try

if( value.equals(password) ) {

}

answered Oct 13 '13 at 08:52

Tamil Selvan C

19,913
12
49
70

score 0 · Answer 4 · edited May 23 '17 at 12:03

Look here

Use the String.equals(String other) function to compare strings, not the == operator.

The function checks the actual contents of the string, the == operator checks whether the references to the objects are equal. Note that string constants are usually "interned" such that two constants with the same value can actually be compared with ==, but it's better not to rely on that.

Can't check string value

4 Answers4