Can't write string to text file two times

Question

i have a two strings with a c# program named eMail & password and i have a regex that check if the text match or not, if the two strings are verified it will save these two strings in 2 different textfiles this is my code:

        string eMail = textBox1.Text;
        string password = textBox2.Text;
        Regex email_Regex = new Regex(@"^([\w\.\-]+)@([\w\-]+)((\.(\w){2,3})+)$");
        Match email_Match = email_Regex.Match(eMail);
        Regex password_Regex = new Regex("^.{4,20}$");
        Match password_Match = password_Regex.Match(password);
        if (!email_Match.Success)
        {
            MessageBox.Show(this,
                "Please Enter A Valid Email Adress !",
                "Error While Connecting !",
                MessageBoxButtons.OKCancel,
                MessageBoxIcon.Error,
                MessageBoxDefaultButton.Button3);
        }
        else if (!password_Match.Success)
        {
            MessageBox.Show(this,
                "Please Enter A Valid Password !",
                "Error While Connecting !",
                MessageBoxButtons.OKCancel,
                MessageBoxIcon.Error,
                MessageBoxDefaultButton.Button3);
        }


        else if (password_Match.Success)
        {
            File.WriteAllText(@"D:\Password.txt", password);
        }

        else if (email_Match.Success)
        {
             File.WriteAllText(@"C:\Email.txt", eMail);
        }

when I debug and i test my program only one textfile is created it the first one ( only the Password.txt ) Any solution ?

Only one branch in an if/elseif/elseif will run. – drch Oct 14 '13 at 11:27 — drch, Oct 14 '13 at 11:27

score 2 · Accepted Answer · answered Oct 14 '13 at 11:27

change it to:

    if (!email_Match.Success)
    {
        MessageBox.Show(this,
            "Please Enter A Valid Email Adress !",
            "Error While Connecting !",
            MessageBoxButtons.OKCancel,
            MessageBoxIcon.Error,
            MessageBoxDefaultButton.Button3);
    }
    else if (!password_Match.Success)
    {
        MessageBox.Show(this,
            "Please Enter A Valid Password !",
            "Error While Connecting !",
            MessageBoxButtons.OKCancel,
            MessageBoxIcon.Error,
            MessageBoxDefaultButton.Button3);
    }

    else
    {
       File.WriteAllText(@"D:\Password.txt", password);
       File.WriteAllText(@"C:\Email.txt", eMail);
    }

because only one else if can be executed, in code above if email and password are correct it will write to both files.

You don't need to check if match is successfull again, because you checked if it is not succesfull before :)

David M · Answer 2 · 2013-10-14T13:13:23.730

1

By the time you've got there, you know both matches are success. Just use:

else (password_Match.Success)
{
    File.WriteAllText(@"D:\Password.txt", password);
    File.WriteAllText(@"C:\Email.txt", eMail);
}

edited Oct 14 '13 at 13:13

answered Oct 14 '13 at 11:29

David M

71,481
13
158
186

you don't need to write `if` -> it's sure that it's successfull match :) – Kamil Budziewski Oct 14 '13 at 11:31

score 0 · Answer 3 · answered Oct 14 '13 at 12:13

0

just change the code in the last 2 "else if" statement

you should remove the "else" from the code

That's all

answered Oct 14 '13 at 12:13

suresh babu

1

Can't write string to text file two times

3 Answers3