Is it bad practice for a class to have only static fields and methods?

Question

I have a class that consists only of static member variables and static methods. Essentially, it is serving as a general-purpose utility class.

Is it bad practice for a class to contain only static member variables and static methods?

Answer 1

No, I don't think so at all. It is worse practice to have a class full of instance methods which don't actually depend on a particular instance. Making them static tells the user exactly how they are intended to be used. Additionally, you avoid unnecessary instantiations this way.

EDIT: As an afterthought, in general I think its nice to avoid using language features "just because", or because you think that that is the "Java way to do it". I recall my first job where I had a class full of static utility methods and one of the senior programmers told me that I wasn't fully harnessing the OO power of Java by making all of my methods "global". She was not on the team 6 months later.

Answer 2

As long as the class has no internal state and is essentially what is known as a leaf class (utility classes fall into this category), in other words it is independent of other classes. It is fine.

The Math class being a prime example.

Answer 3

Sounds reasonable.

Note: Classes that do this often have a private no-arg constructor just so that the compiler yields an error if a programmer tries to create an instance of the static class.

Answer 4

Static methods don't worry me much (except for testing).

In general, static members are a concern. For example, what if your app is clustered? What about start-up time -- what kind of initialization is taking place? For a consideration of these issues and more, check out this article by Gilad Bracha.

Answer 5

It's perfectly reasonable. In fact, in C# you can define a class with the static keyword specifically for this purpose.

Answer 6

Just don't get carried away with it. Notice that the java.lang.Math class is only about math functions. You might also have a StringUtilities class which contains common string-handling functions which aren't in the standard API, for example. But if your class is named Utilities, for example, that's a hint that you might want to split it up.

Answer 7

Note also that Java specifically introduced the static import: (http://en.wikipedia.org/wiki/Static_import)

Static import is a feature introduced in the Java programming language that members (fields and methods) defined in a class as public static to be used in Java code without specifying the class in which the field is defined. This feature was introduced into the language in version 5.0.

The feature provides a typesafe mechanism to include constants into code without having to reference the class that originally defined the field. It also helps to deprecate the practice of creating a constant interface: an interface that only defines constants then writing a class implementing that interface, which is considered an inappropriate use of interfaces[1].

The mechanism can be used to reference individual members of a class:

 import static java.lang.Math.PI;
 import static java.lang.Math.pow;

or all the static members of a class:

 import static java.lang.Math.*;

Answer 8

While I agree with the sentiment that it sounds like a reasonable solution (as others have already stated), one thing you may want to consider is, from a design standpoint, why do you have a class just for "utility" purposes. Are those functionals truly general across the entire system, or are they really related to some specific class of objects within your architecture.

As long as you have thought about that, I see no problem with your solution.

Answer 9

The Collections class in Java SDK has static members only.

So, there you go, as long as you have proper justification -- its not a bad design

Answer 10

Utility methods are often placed in classes with only static methods (like StringUtils.) Global constants are also placed in their own class so that they can be imported by the rest of the code (public final static attributes.)

Both uses are quite common and have private default constructors to prevent them from being instantiated. Declaring the class final prevents the mistake of trying to override static methods.

If by static member variables you did not mean global constants, you might want to place the methods accessing those variables in a class of their own. In that case, could you eleborate on what those variables do in your code?

Answer 11

This is typically how utility classes are designed and there is nothing wrong about it. Famous examples include o.a.c.l.StringUtils, o.a.c.d.DbUtils, o.s.w.b.ServletRequestUtils, etc.

Answer 12

According to a rigid interpretation of Object Oriented Design, a utility class is something to be avoided.

The problem is that if you follow a rigid interpretation then you would need to force your class into some sort object in order to accomplish many things.

Even the Java designers make utility classes (java.lang.Math comes to mind)

Your options are:

double distance = Math.sqrt(x*x + y*y);  //using static utility class

vs:

RootCalculator mySquareRooter = new SquareRootCalculator();
mySquareRooter.setValueToRoot(x*x + y*y);
double distance;
try{
   distance = mySquareRooter.getRoot();
}
catch InvalidParameterException ......yadda yadda yadda.      

Even if we were to avoid the verbose method, we could still end up with:

Mathemetician myMathD00d = new Mathemetician()
double distance = myMathD00d.sqrt(...);

in this instance, .sqrt() is still static, so what would the point be in creating the object in the first place?

The answer is, create utility classes when your other option would be to create some sort of artificial "Worker" class that has no or little use for instance variables.

Answer 13

This link http://java.dzone.com/articles/why-static-bad-and-how-avoid seems to go against most of the answers here. Even if it contains no member variables (i.e. no state), a static class can still be a bad idea because it cannot be mocked or extended (subclassed), so it is defeating some of the principles of OO

Answer 14

I wouldn't be concerned over a utility class containing static methods.

However, static members are essentially global data and should be avoided. They may be acceptable if they are used for caching results of the static methods and such, but if they are used as "real" data that may lead to all kinds of problems, such as hidden dependencies and difficulties to set up tests.

Answer 15

From TSLint’s docs:

Users who come from a Java-style OO language may wrap their utility functions in an extra class, instead of putting them at the top level.

The best way is to use a constant, like this:

export const Util = {
    print (data: string): void {
        console.log(data)
    }
}

Examples of incorrect code for this rule:

class EmptyClass {}

class ConstructorOnly {
  constructor() {
    foo();
  }
}

// Use an object instead:
class StaticOnly {
  static version = 42;
  static hello() {
    console.log('Hello, world!');
  }
}

Examples of correct code for this rule:

class EmptyClass extends SuperClass {}

class ParameterProperties {
  constructor(public name: string) {}
}

const StaticOnly = {
  version: 42,
  hello() {
    console.log('Hello, world!');
  },
};