Random Number Generator, generating the same number

Question

I am creating a Random Number Guessing game, but I have run into the problem of the Generator generating the same number unless I close it and reopen it. I have "Your number is too small/large". That works. But I want the number to change once the button has been clicked to check the guess. Any idea's of what is wrong?

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace Guess_the_number_1
{
    public partial class Form1 : Form
    {
        int randomNumber;

        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            Random random = new Random();
            randomNumber = random.Next(0, 10);

        }

        private void buttonCheckGuess_Click(object sender, EventArgs e)
        {
            if (Convert.ToInt32(textboxGuess.Text) == randomNumber)
            {
                MessageBox.Show("Your Guessed Correctly! The Number Is: " + textboxGuess.Text);
            }
            else if (Convert.ToInt32(textboxGuess.Text) < randomNumber)
            {
                MessageBox.Show("The Number Is Larger Than: " + textboxGuess.Text);

            }
            else if (Convert.ToInt32(textboxGuess.Text) > randomNumber)
            {
                MessageBox.Show("The Number Is Smaller Than: " + textboxGuess.Text);

            }

            else
            {
                MessageBox.Show("Your Guessed Incorrectly. The Random Number Is Not: " + textboxGuess.Text);
            }
        }
    }
}

If you want that to happen, you need to write code to make it happen. The compiler will not magically figure out what you want to do. — SLaks, Oct 17 '13 at 21:13
possible duplicate of [Random number generator only generating one random number](http://stackoverflow.com/questions/767999/random-number-generator-only-generating-one-random-number) — Alexei Levenkov, Oct 17 '13 at 21:13
Because you are making `new Random()` every time, make it once and it will give you different values — nikodz, Oct 17 '13 at 21:14
When do you expect a new `randomNumber` to be created with the provided code? — Austin Salonen, Oct 17 '13 at 21:17

jltrem · Accepted Answer · 2013-10-17T21:42:23.937

Generate your first random number at load, and then again when the user has guessed the correct number.

Put your Random object as a field (class member) and use it in a method:

private void MakeNewRandomNumber()
{
    randomNumber = random.Next(0, 10);
}

Call this method at form load (where you are currently generating a number) and again in the click handler once the guess has been verified:

private void buttonCheckGuess_Click(object sender, EventArgs e)
{
    if (Convert.ToInt32(textboxGuess.Text) == randomNumber)
    {
        MessageBox.Show("Your Guessed Correctly! The Number Is: " + textboxGuess.Text);
        MakeNewRandomNumber();
    }

score 0 · Answer 2 · answered Oct 17 '13 at 21:19

You need to creat a random number each time this button is clicked not just once.

    int randomNumber;

    Random random;

    public Form1()
    {
        InitializeComponent();
        random = new Random();
    }

    private void Form1_Load(object sender, EventArgs e)
    {


    }

    private void buttonCheckGuess_Click(object sender, EventArgs e)
    {

        randomNumber = random.Next(0, 10);

        if (Convert.ToInt32(textboxGuess.Text) == randomNumber)
        {
            MessageBox.Show("Your Guessed Correctly! The Number Is: " + textboxGuess.Text);
        }
        else if (Convert.ToInt32(textboxGuess.Text) < randomNumber)
        {
            MessageBox.Show("The Number Is Larger Than: " + textboxGuess.Text);

        }
        else if (Convert.ToInt32(textboxGuess.Text) > randomNumber)
        {
            MessageBox.Show("The Number Is Smaller Than: " + textboxGuess.Text);

        }

        else
        {
            MessageBox.Show("Your Guessed Incorrectly. The Random Number Is Not: " + textboxGuess.Text);
        }
    }
}

Random Number Generator, generating the same number

2 Answers2