The "if" statement does not work

Question

I have the following Android program code. It does not work even I input "admin", the correct answer. Then I Toast my input which exactly the same as the == "admin". But it still does not work !!! Is there any trick ? Please help !! Many thanks !!

EditText etPassword =(EditText) findViewById(R.id.etPassword);
String t_etPassword =etPassword.getText().toString();

// display the t_etPassword for checking since the "if" does not work
Toast.makeText(getApplicationContext(), "<<" +t_etPassword +">>", Toast.LENGTH_SHORT).show();

if (t_etPassword == "admin") {
    Intent intent = new Intent(getBaseContext(), ContactListActivity.class);
    startActivity(intent);
   } else {
    Toast.makeText(getApplicationContext(), "Un-Authorised Access !!", Toast.LENGTH_SHORT).sho();
    }
  }
});

is this java? never do string comparisons with == always use string libs like lowering both strings and using .equals() or .equalsIgnoreCase() — Mike McMahon, Oct 18 '13 at 05:06
`==` tests for reference equality. `.equals()` tests for value equality. That`s why use .equals() — Rupesh Yadav, Oct 18 '13 at 06:47

score 3 · Answer 1 · edited May 23 '17 at 11:45

3

Try to use 'equals' instead of '=='.

if ("admin".equals(t_etPassword)) {

Explanation: How do I compare strings in Java?

Edit: Dont move the text to a string variable, it's unnecessary. Try this:

EditText etPassword =(EditText) findViewById(R.id.etPassword);
if ("yourpass".equals(etPassword)) {
    Intent intent = new Intent(getBaseContext(), ContactListActivity.class);
    startActivity(intent);
   } else {
    Toast.makeText(getApplicationContext(), "Un-Authorised Access !!", Toast.LENGTH_SHORT).sho();
    }
  }
});

edited May 23 '17 at 11:45

Community

1
1

answered Oct 18 '13 at 05:08

Dancger

172
3
9

1

+1 but to avoid possible NPE, you might want to consider using `"admin".equals(t_etPassword)` – MadProgrammer Oct 18 '13 at 05:17
@MadProgrammer corrected, thank you. – Dancger Apr 05 '16 at 06:54

score 1 · Answer 2 · answered Oct 18 '13 at 05:07

1

if (t_etPassword == "admin")

change above line to

if (t_etPassword.equals("admin"))

now you will get correct answer

answered Oct 18 '13 at 05:07

Dinesh Raj

664
12
30

score 0 · Answer 3 · answered Oct 18 '13 at 05:08

0

Please change this line:

if (t_etPassword == "admin")

to

if (t_etPassword.equals("admin"))

answered Oct 18 '13 at 05:08

user2339071

4,254
1
27
46

score 0 · Answer 4 · answered Oct 18 '13 at 05:08

0

You should use .equals instead:

if(t_etPassword.equals("admin"))

== is checking for reference equality whereas .equals is used to compare values.

answered Oct 18 '13 at 05:08

marteljn

6,446
3
30
43

The "if" statement does not work

4 Answers4