Android Google Map API v2 getTile not always triggered

Question

I recently optimized my TileProvider code for an offline map tiling and I have a new problem where getTile may not be called for up to a minute--and occasionally never--after loading the map or following a CameraChange.

I initialize the TileProvider this way (this is in setUpMap(), onResume(), and within a function that I call if I reset the map or if my offline map's on/off setting is changed):

if (mapsOn()) customOverlay = mMap.addTileOverlay(new TileOverlayOptions().tileProvider
            (new MyTileProvider()));

(I save as customOverlay so that I can call customOverlay.clearTileCache() in onStop() because otherwise I seem to have memory problems.)

And my TileProvider, following the example here, modified to fetch tiles from a zipfile:

public class MyTileProvider implements TileProvider {
    private final int TILE_WIDTH = 256;
    private final int TILE_HEIGHT = 256;
    private static final int BUFFER_SIZE = 16 * 1024;
    private String pathToZipFile = MyConstants.TILE_PROVIDER_PATH_PREFIX;
    private ZipResourceFile zipFile;
    private String currentPath;

    public MyTileProvider()  {
    }

    public Tile getTile(int x, int y, int zoom)  {  
//debug code here shows this is not getting called when the maps are not loading. 
//How do I force it to be called?
        byte[] image = readTileImage(x, y, zoom);
        return image == null ? NO_TILE : new Tile (TILE_WIDTH, TILE_HEIGHT, image);
    }

    private byte[] readTileImage(int x, int y, int zoom)  {
        InputStream in = null;
        ByteArrayOutputStream buffer = null;

        if (zipFile==null) initializeZipFile(x, zoom);

        try {
            in = zipFile.getInputStream(zoom+"/"+x+"/"+y+".png");
            buffer = new ByteArrayOutputStream();
            int nRead;
            byte[] data = new byte[BUFFER_SIZE];

            while ((nRead = in.read(data, 0, BUFFER_SIZE)) != -1) {
                buffer.write(data, 0, nRead);
            }                
            buffer.flush();
            return buffer.toByteArray();

        } catch (IOException e1) {      
            e1.printStackTrace();
            return null;
        } catch (OutOfMemoryError e)  {
            e.printStackTrace();
            return null;
        } finally  {
            if (in!=null) try { in.close(); } catch (Exception ignored)  {}
            if (buffer != null)  try { buffer.close();  } catch (Exception ignored) {}
        }       
    }

    public void initializeZipFile(int x, int zoom)  {       
            //code to choose the correct zip file based upon the zoom level and x coordinate
    }
}

score 1 · Answer 1 · answered Jul 23 '15 at 11:52

1

Use the "@Override" declaration!

  @Override
    public Tile getTile(int x, int y, int zoom) {...}

answered Jul 23 '15 at 11:52

user2001595

11
1

user2808624 · Accepted Answer · 2013-10-27T07:42:44.433

0

I think there is a logical and a technical flaw in your code:

The logical one:
You are using one variable zipFile although you have different files depending on the x and zoom parameter. So even in case zipFile != null, it may contain the wrong content.

If you have e.g. loaded the file for lets say x=1 and zoom=1, you will continue to use this file, even if zoom changed to 2. So just checking for null is not sufficient.

The technical one:
TileProvider must be threadsafe. This is not the case in your coding. You may just add a synchronized to your readTileImage method. But this will probably slow down the whole loading process and it still would not work without resetting the stream each time readTileImage is called. So the "caching" of the stream is not of much help. I think the way you organize the tiles, by having all y-coordinates for the same x and zoom level in the same file makes things that complicated. The map will try to load tiles for different x and y values in parallel. I do not see, how this can be accomplished using the same stream. I would keep a separate file for each x, y, and zoom triple.

edited Oct 27 '13 at 07:42

answered Oct 25 '13 at 06:41

user2808624

2,502
14
28

Re first logical comment: let's say I'm outside of the area where I have tiles stored, is it inherently incorrect to obtain a null InputStream and return null if I am in an area outside where I have offline tiles stored? Or do I need to detect ahead of time that There is no zipFile for the needed content and return null before attempting to get the inputstream? Re the second technical comment: for threadsafe should I do "public synchronized Tile getTile(..."? THANKS – alice_silver_man Oct 26 '13 at 20:37
Please update your post with the code you are currently using. Otherwise it's impossible to judge whats going wrong. – user2808624 Nov 20 '13 at 07:58
I apologize - synchronizing the readTileImage method has fixed the problem. Thanks so much for your help! I have accepted your answer. – alice_silver_man Nov 21 '13 at 23:05

Android Google Map API v2 getTile not always triggered

2 Answers2