mysql query with array as WHERE parameter

Question

there is an email address in the user session, and I am trying to use the extracted info to access the other relevant info on the user from the database. Here is what I have.

$author = explode(":", $_SESSION['user_id']);

$query = mysql_query("SELECT * FROM users WHERE `active`='1' AND `email`=$author[1]");

while ($query_row = mysql_fetch_assoc($query)) {

// does stuff in here.

}

for some reason I get back "mysql_fetch_assoc() expects parameter 1 to be resource, boolean given." If I echo out "$author['1']" I get the correct email address for the logged in user. How do I go about writing the query correctly?

need to put single quotes arroud this in `$author['1']` – M Khalid Junaid Oct 25 '13 at 19:36 — M Khalid Junaid, Oct 25 '13 at 19:36

score 1 · Accepted Answer · answered Oct 25 '13 at 19:37

1

You should put:

"SELECT * FROM users WHERE active='1' AND email='".$author[1]."'"

make sure you have propper quotes up there

answered Oct 25 '13 at 19:37

Mirosław Karczmarczyk

227
1
11

score 0 · Answer 2 · answered Oct 25 '13 at 19:39

0

$qry ="SELECT * FROM users WHERE `active`='1' AND `email`= ".$author['1'];
$query = mysql_query($qry);

answered Oct 25 '13 at 19:39

Deepak Rai

2,163
3
21
36

An explanation of what you are doing differently and why would be helpful. – showdev Oct 25 '13 at 19:59

score 0 · Answer 3 · edited Oct 25 '13 at 19:39

0

$query = mysql_query("SELECT * FROM users WHERE `active`='1' AND `email`='".$author[1]."'");

edited Oct 25 '13 at 19:39

M Khalid Junaid

63,861
10
90
118

answered Oct 25 '13 at 19:39

Adnan

579
1
4
11

1

An explanation of what you are doing differently and why would be helpful. – showdev Oct 25 '13 at 19:59

score 0 · Answer 4 · answered Oct 25 '13 at 19:44

You can enclose variable in quotes with curly brackets:

$query = mysql_query("SELECT * FROM users WHERE `active`='1' AND `email`={$author[1]}");

Although I have one more tip: run queries like this : $query = mysql_query('...') or die(mysql_error()); With this you will at least know why it fails.

P.S. I guess you have a reason to use mysql extension, but anyway you should use PDO or mysqli over mysql. You get placeholders with mysqli, or named parameters with PDO. Much nicer to work with.

mysql query with array as WHERE parameter

4 Answers4