Uploading Multiple Files Php

Question

Ok guys, I have searched for an answer and I could not find anything to help. I tried using a while loop and a forloop but only one file ever gets uploaded. Here is my code.

Form:

<form method="post" enctype="multipart/form-data" action="process.php">
<div id="filediv">
<div id="imagefiles">
<input type="hidden" name="MAX_FILE_SIZE" value="2000000">
<label>Upload File:
<input name="userfile[]" type="file" id="userfile" multiple></label>
<label>Alt Text: <input name="alt" type="text"></label>
 </div>
 </div>

Here is the upload function:

$alt=mysqli_real_escape_string($conn, $_POST['alt']);
foreach($_FILES['userfile']['tmp_name'] as $key => $tmp_name ){
if (($_FILES["userfile"]["error"] == 0) && ($_FILES['userfile']['size'] > 0))
{
$fileName = $_FILES['userfile']['name'][$key];
$tmpName  = $_FILES['userfile']['tmp_name'][$key];
$fileSize = $_FILES['userfile']['size'][$key];
$fileType = $_FILES['userfile']['type'][$key];
} else{
    echo"error";
}

$allowedExts = array("jpg", "jpeg", "gif", "png");
$extension = end(explode(".", $_FILES["userfiles"]["name"]));
if((($_FILES["userfile"]["type"] == "image/gif")
    ||($_FILES["userfile"]["type"]=="image/jpeg")
    ||($_FILES["userfile"]["type"]=="image/png")
    ||($_FILES["userfile"]["type"]=="image/pjpeg")
    && in_array($extension, $allowedExts)))
    {
        $fp = fopen($tmpName, 'r');
        $content =fread($fp, filesize($tmpName));
        $SourceImage = imagecreatefromstring($content);
        $SourceWidth = imagesx($SourceImage);
        $SourceHeight=imagesy($SourceImage);
        $DestWidth=100;
        $DestHeight=130;
        if ($SourceHeight> $SourceWidth)
        {$ratio = $DestHeight / $SourceHeight;
        $newHeight = $DestHeight;
        $newWidth = $sourceWidth * $ratio;
        }
        else
        {
            $ratio = $DestWidth / $SourceWidth;
            $newWidth = $DestWidth;
            $newHeight = $SourceHeight * $ratio;
        }
        $DestinationImage = imagecreatetruecolor($newWidth, $newHeight);
        imagecopyresampled($DestinationImage, $SourceImage, 0,0,0,0,$DestWidth, $DestHeight, $SourceHeight, $SourceWidth);
        ob_start();
        imagejpeg($DestinationImage);
        $BinaryThumbnail = ob_get_contents();
        ob_end_clean();
        $thumb = addslashes($BinaryThumbnail);
        $content = addslashes($content);
        fclose($fp);
        $fp      = fopen($tmpName, 'r');
$content = fread($fp, filesize($tmpName));
$content = addslashes($content);
fclose($fp);

         mysqli_query($conn, "INSERT INTO files (username, name, size, content, type, link, alt, thumbnail) VALUES ('$username', '$fileName', '$fileSize', '$content', '$fileType', 1, '$alt', '$thumb')") or die('Error, query failed'); 
           echo "<script>alert('The file has been uploaded');location.replace('uploaded.php');</script>";
           unlink ($_FILES['username']['tmp_name']);
    }else{ 
           echo "<script>alert('Please upload an image');location.replace('upload.php');</script>";
    }

}
}

I realized that I didn't need half the code that I had. Now I have one image uploading but not both again.

Answer 1

I might be wrong, I'm not sure I ever coded a $_FILE array....but I think the issue is here

 while ($_FILES["userfile'"]["tmp_name"][$counter]){

besides the extra quote I don't think the data is stored like that...you can try doing print_r($_FILES)

It might be

$_FILES["userfile"][$counter]["tmp_name"]

but I'm actually doubting if this will even work. Just loop through the $_FILE array itself to handle an dynamic number of files....here is the function I use....

public static function upload($file, $accountDirectory, $uploadDirectory)
{
    $return = array();
    if(!file_exists($file['tmp_name']) || !is_uploaded_file($file['tmp_name'])) {
        $return["result"] = false;
    }
    if($file['error'] != UPLOAD_ERR_OK) {
         $return["result"] = false; 
          switch($file['error']){
            case 0: //no error; possible file attack!
              echo "There was a problem with your upload.";
              break;
            case 1: //uploaded file exceeds the upload_max_filesize directive in php.ini
              echo "The file you are trying to upload is too big.";
              break;
            case 2: //uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the html form
              echo "The file you are trying to upload is too big.";
              break;
            case 3: //uploaded file was only partially uploaded
              echo "The file you are trying upload was only partially uploaded.";
              break;
            case 4: //no file was uploaded
              echo "You must select an image for upload.";
              break;
            default: //a default error, just in case!  :)
              echo "There was a problem with your upload.";
              break;            
          }         
    } else {
        $newFileName = preg_replace("/[^a-zA-Z0-9-.]/", "", $file["name"]);
        $uploadLocation = $accountDirectory . $uploadDirectory . $newFileName;
        while (file_exists($uploadLocation)) {
            $uploadLocation = $accountDirectory . $uploadDirectory . time() . $newFileName;
        }
        if (move_uploaded_file($file["tmp_name"],$uploadLocation)==true) {
            $return["file"] = str_replace($accountDirectory, "/",$uploadLocation);
            $return["result"] = true;
        } else {
            $return["result"] = false;
        }
    }
    return $return;
}

Answer 2

By doing $_FILES['userfile'] and $_FILES['file'], you are referring only to files uploaded via upload fields with those names (userfile and file, respectively). $_FILES is an associative array, so you should do something like

foreach ($_FILES as $fieldName => $fileProperties) {
    // do something
}

Also, note that you have $_FILES["userfile'"] about a dozen lines down; the extra ' will break that line.

See the PHP help files for more info.