How get the last 4 letters of the name

Question

In a _form, I have a field to upload files. What I am trying to do is check if the file contains a dangerous extension.

In my case, I return an error message if the extension is one of the following: . 'bat'. 'with'. 'exe'. 'src',. 'cmd'

So I did this:

def suspitious_attachment        
  if ends_with? '.bat', '.com', '.exe', '.src', '.cmd'
    errors.add(:base, I18n.t('errors.messages.suspitious_attachment', :value => attachments.split(".").last))
  end
end

But it is not a good idea, a file can have multiple dot in the name.

So I would like to get the last 4 letters of the name.

I'm not able to do this, can you help me?

Sorry for my English.

How would checking the last four letters make difference? – sawa Oct 31 '13 at 03:41 — sawa, Oct 31 '13 at 03:41

falsetru · Accepted Answer · 2013-10-31T03:42:24.530

3

You can use [-4..-1] or [-4, 4]:

'this.is.really.dangerous.file.exe'[-4..-1]
# => ".exe"
'this.is.really.dangerous.file.exe'[-4, 4]
# => ".exe"
'a_file.rb'[-4..-1]
# => "e.rb"

But File::extname is more appropriate to get filename.

File.extname 'a_file.cmd'
# => ".cmd"
File.extname 'a_file.rb'
# => ".rb"
File.extname 'this.is.really.dangerous.file.exe'
# => ".exe"

edited Oct 31 '13 at 03:42

answered Oct 31 '13 at 03:35

falsetru

357,413
63
732
636

score 2 · Answer 2 · edited May 23 '17 at 10:25

2

You're lulling yourself into a false sense of security here. Checking the name of the file will not prevent someone from uploading a file with a fake extension.

If you need to verify the file format, you should check against the MIME type instead.

See more here: How to check in rails uploaded file type?

edited May 23 '17 at 10:25

Community

1
1

answered Oct 31 '13 at 03:56

Tyler

11,272
9
65
105

How get the last 4 letters of the name

2 Answers2