infinite loop. anyone have any ideas?

Question

public int sum (int num1, int num2){
    int sum = 0;
        if(num2>num1){
        for (int i = num1; i<=num2; i++){
            sum = sum + i;
            }
        }
        else{
        for (int i = num2; i <= num1; i++){
            sum = sum + i;
            }
        }
    System.out.println("The sum between " +num1+ " and " +num2+ " equals " + sum);
    return sum(num1, num2);
    }
}

infinite loop problem. any fixes? trying to find the sum of all the numbers between two inputs. this is the class definition any ideas?

Format your code legibly. Then, only have one version of the loop. Specify that the caller needs to provide the lower number first, and then provide another method that you can call that will swap them around if necessary, so that your code is simpler and easier to follow. — chrylis -cautiouslyoptimistic-, Oct 31 '13 at 04:33
Hello, Follow coding standards.Same name for variable and function. unacceptable. @chrylis : thanks dude. — Chandan Kumar, Oct 31 '13 at 04:41
Possible duplicate of [What is a debugger and how can it help me diagnose problems](http://stackoverflow.com/questions/25385173/what-is-a-debugger-and-how-can-it-help-me-diagnose-problems) — Raedwald, Feb 08 '16 at 16:27

score 2 · Answer 1 · answered Oct 31 '13 at 04:32

2

You're calling sum() again, and without any condition to check when to break the recursion. Hence an infinite loop

As the other answers have pointed out, you have to replace return sum(num1,num2); with return sum;

answered Oct 31 '13 at 04:32

Aniket Inge

25,375
5
50
78

Thank you, i appreciate the quick response – Oct 31 '13 at 04:41
Not a problem. Happy to help :-) @CaseyButo – Aniket Inge Oct 31 '13 at 04:41

score 2 · Answer 2 · answered Oct 31 '13 at 04:36

2

In place of return sum(num1, num2); you should return sum;

answered Oct 31 '13 at 04:36

Dhruv Pal

849
2
10
25

sam · Answer 3 · 2013-10-31T04:47:30.070

public int sum (int num1, int num2)
{
   int sum = 0;
   if(num2>num1)
   {
        for (int i = num1; i<=num2; i++)
        {
            sum = sum + i;
         }
   }
   else
   {
        for (int i = num2; i <= num1; i++)
        {
            sum = sum + i;
        }
    }
    System.out.println("The sum between " +num1+ " and " +num2+ " equals " + sum);
    return sum;  
  }

you were doing recursive calling thats the problem..

score 0 · Answer 4 · edited Oct 31 '13 at 04:35

0

You are calling the function recursively by return sum(num1, num2);. So change return sum(num1, num2); to return sum;

edited Oct 31 '13 at 04:35

Linga

10,379
10
52
104

answered Oct 31 '13 at 04:34

upog

4,965
8
42
81

infinite loop. anyone have any ideas?

4 Answers4