add "attribute" or Class to variable

Question

I am working on slideshow. At the end I want to add current class to my variable for next checking.

But that's not work, I also tried attr but not working.

this is my code:

    $(function () {
        $('.large_image').children('img').addClass('current');
        $('.product-item').click(function () {
            if ($('.large_image > img').hasClass('current')) {
                var $img = $(this).find('img').attr('data-img');
                var $slider = '<img class="dis-none" style="position:absulote;z-index:999" src=' + $img + ' />';
                $($slider).appendTo('.large_image').stop(true, true).delay(400).fadeIn(
                   function () {
                       $('.current').fadeOut(function () {
                           $(this).remove();

                       });
                   });
                $($slider).attr('class', 'current');
                $($slider).addClass('current');
            }
        })
    });

Any help on how to resolve this issue?

score 3 · Accepted Answer · answered Nov 04 '13 at 09:06

3

Firstly, your variable name is $slider, not slider. You'll need to add a $ before slider: $($slider). After fixing this, you can simply use jQuery's addClass() method:

$($slider).addClass('current');

jQuery also has a removeClass() method to remove the class, so before setting the new slide to "current", you may want to call:

$('.current').removeClass('current');

answered Nov 04 '13 at 09:06

James Donnelly

126,410
34
208
218

thanks for help but not working yet,i'm try `addClass` and `attr` also, but my problem not solved – Hamed mayahian Nov 04 '13 at 09:22
Are you getting any JavaScript errors in the console? Are you sure the class isn't actually getting added to your `$slider` element? – James Donnelly Nov 04 '13 at 09:22
no,i'm also add the alert and that show me: `` and class `current` not added – Hamed mayahian Nov 04 '13 at 09:25
Why don't you simply give it the "current" class when you first create the element? `var $slider = ' – James Donnelly Nov 04 '13 at 09:27
because in the next line i remove the previous slide,that has current class,at the end i should add new current class to next element; – Hamed mayahian Nov 04 '13 at 09:31

score 1 · Answer 2 · answered Nov 04 '13 at 09:07

1

use addClass() to add a class attribute

$(slider).addClass("current");

answered Nov 04 '13 at 09:07

Arun P Johny

384,651
66
527
531

score 1 · Answer 3 · edited Jun 20 '20 at 09:12

1

Below is the actual mistake in your code.

$($slider).attr("class='current'"); //WRONG
$($slider).attr('class','current'); //RIGHT WAY

or simply using addClass() method

$($slider).addClass('current');

Check this Benefits of using attr() over addClass in jquery

addClass() has several benefits over manipulating the class with attr('class'):

It's semantically clearer.

It works with multiple classes.

It's apparently a lot faster.

edited Jun 20 '20 at 09:12

Community

1
1

answered Nov 04 '13 at 09:08

Praveen

55,303
33
133
164

thanks but not working yet,i'm add you code `addClass()` and `attr` but not working for me! – Hamed mayahian Nov 04 '13 at 09:20

score 1 · Answer 4 · answered Nov 04 '13 at 09:08

1

use add class and remove class

$(slider).addClass('current').siblings().removeClass('current');

It also removes other elaments current class

answered Nov 04 '13 at 09:08

Sridhar R

20,190
6
38
35

add "attribute" or Class to variable

4 Answers4