Stop python from going to the very last statement

Question

I am currently writing a program that will solve the pythagorean theorem. However, I have a bug in the program. Whenever I put in a negative number for length a or b, it prints out "A cannot be less than zero" but goes ahead and solves for C anyway and prints out the length of C even though the user hasn't input b yet. How can I make it so when the user inputs a negative number it prints out the statement "A cannot be less than zero" and then loops again to inputting a length for the side, instead of how it is now where after it prints out the statement it redirects to the end?

Here is my code:

 import math
    print"This program will solve the pythagorean theorem for you"
    unit=raw_input('Enter the unit you will be using')
    a=float(raw_input('Enter the length of side a'))
    if a<=0:
      print"A cannot be less than zero"
    else:
        b=float(raw_input('Enter the length of side b'))
    if b<=0:
      print"B cannot be less than zero"
    else:
        c2=(a**2)+(b**2)
        c=math.sqrt(c2)
        c=str(c)
        print "The length of side C is: "+ c + " " + unit + "."

look at how you are chaining statements together; indentation is important — crownedzero, Nov 07 '13 at 17:25
Here's a thought for you: you might want to put your input & validation code into a function, calling it for both side a and side b. — Fred Larson, Nov 07 '13 at 17:28
I would like to show you a way using neat functions. I hope you can hold on for that :) — Games Brainiac, Nov 07 '13 at 17:35
also for the OP what happens if a side is zero? just a small logic issue. your can also cast at the input by calling float(raw_input('Enter the length of side a: ')) iirc — crownedzero, Nov 07 '13 at 17:35

score 3 · Answer 1 · answered Nov 07 '13 at 17:26

You missed one indentatino level. Try it like this :

if a<0:
  print"A cannot be less than zero"
else:
    b=raw_input('Enter the length of side b')
    b=float(b)
    if b<0:
        print"B cannot be less than zero"
    else:
        c2=(a**2)+(b**2)
        c=math.sqrt(c2)
        c=str(c)
        print "The length of side C is: "+ c + " " + unit + "."

Paulo Scardine · Answer 2 · 2013-11-07T17:59:59.077

Try to avoid using nested if when designing the program flow. It leads to this kind of bug (missing one level of indentation). Big chunks of code inside if blocks and many nested if blocks make the program harder to follow and reason about.

Instead, you can ask again until the input is valid:

a = -1
while a < 0:
    try:
        a=float(raw_input('Enter the length of side a'))
    except ValueError:
        pass
    if a<0:
        print "A cannot be less than zero"

Fred's advice is good, wrap it into a function for reuse:

def validate(initial, prompt, test, message, typecast=str):
    value = initial
    while not test(value):
        try:
            value = typecast(raw_input(prompt))
        except ValueError:
            print "Invalid value"
            continue

        if not test(value):
            print message
            continue

        return value

Then use:

a = validate(
    initial = -1, 
    prompt = 'Enter the length of side A', 
    test = lambda x: x >= 0,
    message = "A cannot be less than zero",
    typecast = float
)
b = validate(
    initial = -1, 
    prompt = 'Enter the length of side B', 
    test = lambda x: x >= 0,
    message = "B cannot be less than zero",
    typecast = float,
)

While this does make it work, it doesn't help the OP understand what he did wrong, and how to avoid it in the future, i.e. it doesn't actually solve the problem, nor does it answer the OP's question (strictly speaking). Adding more information would be really helpful. — Matt, Nov 07 '13 at 17:31
@crownedzero fixed that for you. Made it so it makes it a float on the same line plus it checks if it is less than or equal to zero — Domecraft, Nov 07 '13 at 17:36

score 2 · Accepted Answer · answered Nov 07 '13 at 17:46

Well to begin with, if you want to constantly check your inputs, you are going to have to use a loop. As in, the psuedocode for the algorithm should be:

Loop Begin
Check the value of a and b
If a or b is less than 0 then ask for input again
Otherwise, continue

Please note, that the algorithm has to run at least once.

That is basically how the psuedocode should look like. So, this is a case where you can use a do-while loop construct. In Python, there isn't something like this, so we emulate it:

import math


def take_in():
    a = raw_input("Enter the value of side a -> ")
    b = raw_input("Enter the value of side b -> ")

    # Trying to convert to a float
    try:
        a, b = float(a), float(b)
        # If successfully converted, then we return
        if a > 0 and b > 0:
            return a, b
    except ValueError:
        pass
    # If we cannot return, then we return false, with a nice comment

    print "Invalid input"
    return False


def main():
    # Calling the function at least once
    valid = take_in()

    # While we are not getting valid input, we keep calling the function
    while not valid:
        # Assigning the value to valid
        valid = take_in()

    # Breaking the return tuple into a and b
    a, b = valid
    print math.sqrt(a ** 2 + b ** 2)


if __name__ == '__main__':
    main()

@Domecraft That question has been asked on several occasions. Here is a [good answer](http://stackoverflow.com/questions/419163/what-does-if-name-main-do) to it. — Games Brainiac, Nov 07 '13 at 17:51
@GamesBrainiac lol we kinda had the same idea breaking it down — crownedzero, Nov 07 '13 at 17:52

score 0 · Answer 4 · answered Nov 07 '13 at 17:48

disclaimer: I'm using a different version of Python so mileage may vary

import math

a = 0
b = 0

def py_theorem(a, b):
    return(a**2 + b**2)


unit = raw_input('Enter the unit you will be using: ')

while a <= 0:
a = float(raw_input('Enter the length of side A: '))
if a <= 0:
    print('A cannot be less than 0.')

while b <= 0:
b = float(raw_input('Enter the length of side B: '))
if b <= 0:
    print('B cannot be less than 0.')

print('The length of the 3rd side C is %d %s') % (py_theorem(a,b), unit)

Now if you look at my code a,b are 0 initially so you can execute the while loops (otherwise you get an error, the interpreter doesn't know about a,b up to that point). Then it repeats the statements asking for a,b respectively until you get valid input (valid in a generic sense, we do no error checking, what happens if you use a string?? >.<) Now the print is a little funky, I'd definitely look into the Python docs and see what %d %s etc are. Then we pass the return of the method (see the def py_theorem up top) to the string along with a unit. Note that the function takes two arguments a,b respectively.

Stop python from going to the very last statement

4 Answers4