Can't find toupper and erase

Question

So, I've been doing Reddit's daily programmer #140 and can't use std::toupper and std::erase.

Includes:

#include <iostream>
#include <string>
#include <cctype>

Part with toupper and erase (used to transform words to 'CamelCase'):

std::string tekst;
std::cin >> tekst;    

tekst[0] = std::touppper(tekst[0]);
for(unsigned int i = 0; i < tekst.size(); i++){
    if(tekst[i] == 32){
        std::erase(tekst[i], 1);
        tekst[i] = std::toupper(tekst[i]);
    }
}

And compiler shows errors:

error: 'touppper' is not a member of 'std'
error: 'erase' is not a member of 'std'

What can cause it? Thanks in advance!

@chris [Oh rly?](http://en.cppreference.com/w/cpp/string/byte/toupper) — , Nov 09 '13 at 20:19
You don't specify compiler but in MSVC you'd need to `#include ` — Roger Rowland, Nov 09 '13 at 20:21
@H2CO3: The link you posted was to `toupper` (with two `p`s), while chris commented on the one in the question here, which is `touppper` (3 `p`s). The poster's version is in fact not part of the `std` namespace. — Ken White, Nov 09 '13 at 20:22
[No erase in namespace std](http://en.cppreference.com/mwiki/index.php?title=Special%3ASearch&search=erase). — n. m. could be an AI, Nov 09 '13 at 20:22
There is an `erase` member function in `string`: should be `tekst.erase(i, 1)` — wkordalski, Nov 09 '13 at 20:23
@H2CO3: Sorry. Forgot the :D in my last comment. It was meant as a joke. The error the poster quoted does in fact have three `p`s in it, though. — Ken White, Nov 09 '13 at 20:25
@KenWhite Now I feel bad. Upvoted that. I'm somehow not getting jokes today. :D Sorry... — , Nov 09 '13 at 20:26

score 4 · Answer 1 · answered Nov 09 '13 at 20:20

4

Not

std::touppper

but

std::toupper

You need to pass a locale to the function, see for example: http://www.cplusplus.com/reference/locale/toupper/

answered Nov 09 '13 at 20:20

piokuc

25,594
11
72
102

score 1 · Accepted Answer · edited May 23 '17 at 11:50

1

std::touppper does not exist, as it is spelled with two p's, not with three :). std::erase is not a standard function, check this: Help me understand std::erase

edited May 23 '17 at 11:50

Community

1
1

answered Nov 09 '13 at 20:24

Rontogiannis Aristofanis

8,883
8
41
58

Oh God, thank you for sparing your time for such noob as me :) – Demiu Nov 09 '13 at 20:30
@user2974775 this mistake could happen to anyone, don't judge yourself :) – Rontogiannis Aristofanis Nov 10 '13 at 08:52

score 0 · Answer 3 · answered Nov 09 '13 at 20:29

You probaly want to use std::toupper() as the basis of your implementation. Note, however, that std::toupper() takes its argument as int and requires that the argument is a positive value of EOF. Passing negative values to the one argument version of std::toupper() will result in undefined behavior. On platforms where char is signed you will easily get negative values, e.g., when using ISO-Latin-1 encoding with my second name. The canonical approach is to use std::toupper() with the char convert to an unsigned char:

tekstr[0] = std::toupper(static_cast<unsigned char>(tekstr[0]));

With respect to erase() you are probably looking for std::string::erase():

tekstr.erase(i);

Note that if the string ends in a space, you don't want to access the character at index i after blowing the last space away!

Can't find toupper and erase

3 Answers3